Refactor testing (#210)

* Overhaul testing.

Author: wmedrano

.config/nextest.toml

@@ -1,5 +1,5 @@
 [profile.default]
 test-threads = 1
 fail-fast = false
-slow-timeout = { period = "30s", terminate-after = 4 }
-retries = { backoff = "fixed", count = 2, delay = "1s" }
+slow-timeout = { period = "2s", terminate-after = 2 }
+retries = { backoff = "fixed", count = 3, delay = "1s" }

Cargo.toml

@@ -18,8 +18,10 @@ libc = "0.2"
 log = { version = "0.4", optional = true}
 
 [dev-dependencies]
+approx = "0.5"
 crossbeam-channel = "0.5"
+ctor = "0.2"
 
 [features]
 default = ["dynamic_loading", "log"]
-dynamic_loading = ["jack-sys/dynamic_loading"]
+dynamic_loading = ["jack-sys/dynamic_loading"]

README.md

@@ -12,7 +12,8 @@ Rust bindings for [JACK Audio Connection Kit](<https://jackaudio.org>).
 
 The JACK server is usually started by the user or system. Clients can request
 that the JACK server is started on demand when they connect, but this can be
-disabled by creating a client with the `NO_START_SERVER` option.
+disabled by creating a client with the `NO_START_SERVER` option or
+`ClientOptions::default()`.
 
 -   Linux and BSD users may install JACK1, JACK2 (preferred for low latency), or
     Pipewire JACK (preferred for ease of use) from their system package manager.

docs/contrib/closure_callbacks.md

@@ -18,7 +18,7 @@ contains captures the required state and then activating it.
 ```rust
 // 1. Create the client.
 let (client, _status) =
-    jack::Client::new("silence", jack::ClientOptions::NO_START_SERVER).unwrap();
+    jack::Client::new("silence", jack::ClientOptions::default()).unwrap();
 
 // 2. Define the state.
 let mut output = client.register_port("out", jack::AudioOut::default());
@@ -45,7 +45,7 @@ buffer size.
 ```rust
 // 1. Create the client.
 let (client, _status) =
-    jack::Client::new("silence", jack::ClientOptions::NO_START_SERVER).unwrap();
+    jack::Client::new("silence", jack::ClientOptions::default()).unwrap();
 
 // 2. Define the state.
 struct State {

docs/features.md

@@ -37,10 +37,3 @@ Default: Yes
 Load `libjack` at runtime as opposed to the standard dynamic linking. This is
 preferred as it allows `pw-jack` to intercept the loading at runtime to provide
 the Pipewire JACK server implementation.
-
-## `metadata`
-
-Default: No
-
-Provides access to the metadata API. This is experimental. Details on the JACK
-metadata API can be found at <https://jackaudio.org/metadata/>.

docs/logging.md

@@ -27,15 +27,16 @@ enabled by default. The `log` crate provides a *facade* for logging; it provides
 macros to perform logging, but another mechanism or crate is required to
 actually perform the logging.
 
-In the example below, we use the [`env_logger` crate]() to display logging for
-info and error severity level messages.
+In the example below, we use the [`env_logger`
+crate](https://crates.io/crates/env_logger) to display logging for info and
+error severity level messages.
 
 ```rust
 env_logger::builder().filter(None, log::LevelFilter::Info).init();
 
 // JACK may log things to `info!` or `error!`.
 let (client, _status) =
-      jack::Client::new("rust_jack_simple", jack::ClientOptions::NO_START_SERVER).unwrap();
+      jack::Client::new("rust_jack_simple", jack::ClientOptions::default()).unwrap();
 ```
 
 

docs/quickstart.md

@@ -55,7 +55,7 @@ program that can take inputs and forward them to outputs.
 fn main() {
     // 1. Create client
     let (client, _status) =
-        jack::Client::new("rust_jack_simple", jack::ClientOptions::NO_START_SERVER).unwrap();
+        jack::Client::new("rust_jack_simple", jack::ClientOptions::default()).unwrap();
 
     // 2. Register ports. They will be used in a callback that will be
     // called when new data is available.

examples/internal_client.rs

@@ -6,7 +6,7 @@ fn main() {
     // Create client
     let (client, _status) = jack::Client::new(
         "rust_jack_internal_client_tester",
-        jack::ClientOptions::NO_START_SERVER,
+        jack::ClientOptions::default(),
     )
     .unwrap();
 

examples/playback_capture.rs

@@ -6,7 +6,7 @@ fn main() {
     // Create client
     jack::set_logger(jack::LoggerType::Stdio);
     let (client, _status) =
-        jack::Client::new("rust_jack_simple", jack::ClientOptions::NO_START_SERVER).unwrap();
+        jack::Client::new("rust_jack_simple", jack::ClientOptions::default()).unwrap();
 
     // Register ports. They will be used in a callback that will be
     // called when new data is available.

examples/set_transport.rs

@@ -2,7 +2,7 @@ use std::env;
 
 fn main() {
     let (client, _status) =
-        jack::Client::new("rust_jack_trans", jack::ClientOptions::NO_START_SERVER).unwrap();
+        jack::Client::new("rust_jack_trans", jack::ClientOptions::default()).unwrap();
 
     let transport = client.transport();