Skip to content

Commit a6a5cfc

Browse files
committed
Allow deviations +-2 instead of 1
On newer compiler versions, deviations +-2 seem to happen. Instead of increasing the number of diffing packets in the offending files, let's just allow larger differences. So much for llvm being float exact.
1 parent 17cf6ae commit a6a5cfc

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

dev/cmp/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,8 @@ pub fn cmp_output<R :Read + Seek, T, F :Fn(usize, usize, usize,
152152
let mut diffs = 0;
153153
for (s,n) in dec_data.iter().zip(native_dec_data.iter()) {
154154
let diff = *s as i32 - *n as i32;
155-
// +- 1 deviation is allowed.
156-
if diff.abs() > 1 {
155+
// +- 2 deviation is allowed.
156+
if diff.abs() > 2 {
157157
diffs += 1;
158158
}
159159
}

dev/cmp/tests/vals.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ fn test_vals() {
3535
cmp_output!("bwv_543_fuge.ogg", 0);
3636
cmp_output!("maple_leaf_rag.ogg", 0);
3737
cmp_output!("hoelle_rache.ogg", 0);
38-
cmp_output!("thingy-floor0.ogg", 1);
38+
cmp_output!("thingy-floor0.ogg", 0);
3939
cmp_output!("audio_simple_err.ogg", 0);
4040
}
4141

@@ -79,7 +79,7 @@ fn test_libnogg_vals() {
7979
ensure_okay!("single-code-ordered.ogg");
8080
cmp_output!("single-code-sparse.ogg", 0);
8181
#[cfg(not(target_os = "macos"))]
82-
cmp_output!("sketch008-floor0.ogg", 4);
82+
cmp_output!("sketch008-floor0.ogg", 0);
8383
cmp_output!("sketch008.ogg", 0);
8484
cmp_output!("sketch039.ogg", 0);
8585
cmp_output!("split-packet.ogg", 2);
@@ -131,7 +131,7 @@ fn test_xiph_vals_3() {
131131
println!();
132132

133133
cmp_output!("lsp-test.ogg", 0);
134-
cmp_output!("lsp-test2.ogg", 2);
134+
cmp_output!("lsp-test2.ogg", 0);
135135
cmp_output!("lsp-test3.ogg", 0);
136136
cmp_output!("lsp-test4.ogg", 0);
137137
cmp_output!("mono.ogg", 0);
@@ -162,8 +162,8 @@ fn test_xiph_vals_5() {
162162

163163
cmp_output!("singlemap-test.ogg", 0);
164164
#[cfg(not(target_os = "macos"))]
165-
cmp_output!("sleepzor.ogg", 9);
166-
cmp_output!("test-short.ogg", 1);
165+
cmp_output!("sleepzor.ogg", 0);
166+
cmp_output!("test-short.ogg", 0);
167167
cmp_output!("test-short2.ogg", 0);
168168
// Contains an out of bounds mode index
169169
ensure_malformed!("unused-mode-test.ogg", BadAudio(AudioBadFormat));

0 commit comments

Comments
 (0)