Skip to content

Commit ffd915e

Browse files
Dan CarpenterThomas Hellström
authored andcommitted
drm/xe/device: clean up on error in probe()
This error path should clean up before returning. Smatch detected this bug: drivers/gpu/drm/xe/xe_device.c:487 xe_device_probe() warn: missing unwind goto? Fixes: 4cb12b7 ("drm/xe/xe2: Determine bios enablement for flat ccs on igfx") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Matthew Brost <matthew.brost@intel.com> Reviewed-by: Matthew Brost <matthew.brost@intel.com> (cherry picked from commit c10da95) Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
1 parent 190db3b commit ffd915e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/xe/xe_device.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ int xe_device_probe(struct xe_device *xe)
484484

485485
err = xe_device_set_has_flat_ccs(xe);
486486
if (err)
487-
return err;
487+
goto err_irq_shutdown;
488488

489489
err = xe_mmio_probe_vram(xe);
490490
if (err)

0 commit comments

Comments
 (0)