Skip to content

Commit feb8597

Browse files
committed
cgroup/dmem: Fix parameters documentation
During the dmem cgroup development, the parameters to the dmem_cgroup_state_evict_valuable() and dmem_cgroup_try_charge() were changed, but the documentation wasn't adjusted accordingly. This results in a documentation build warning. Adjust the documentation to reflect what the final functions parameters are. Fixes: b168ed4 ("kernel/cgroup: Add "dmem" memory accounting cgroup") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/r/20250113160334.1f09f881@canb.auug.org.au/ Acked-by: Tejun Heo <tj@kernel.org> Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20250113092608.1349287-2-mripard@kernel.org Signed-off-by: Maxime Ripard <mripard@kernel.org>
1 parent e33b514 commit feb8597

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

kernel/cgroup/dmem.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,6 @@ dmem_cgroup_calculate_protection(struct dmem_cgroup_pool_state *limit_pool,
280280

281281
/**
282282
* dmem_cgroup_state_evict_valuable() - Check if we should evict from test_pool
283-
* @dev: &dmem_cgroup_region
284-
* @index: The index number of the region being tested.
285283
* @limit_pool: The pool for which we hit limits
286284
* @test_pool: The pool for which to test
287285
* @ignore_low: Whether we have to respect low watermarks.
@@ -610,13 +608,12 @@ EXPORT_SYMBOL_GPL(dmem_cgroup_uncharge);
610608

611609
/**
612610
* dmem_cgroup_try_charge() - Try charging a new allocation to a region.
613-
* @dev: Device to charge
611+
* @region: dmem region to charge
614612
* @size: Size (in bytes) to charge.
615613
* @ret_pool: On succesfull allocation, the pool that is charged.
616614
* @ret_limit_pool: On a failed allocation, the limiting pool.
617615
*
618-
* This function charges the current pool for @dev with region at @index for a
619-
* size of @size bytes.
616+
* This function charges the @region region for a size of @size bytes.
620617
*
621618
* If the function succeeds, @ret_pool is set, which must be passed to
622619
* dmem_cgroup_uncharge() when undoing the allocation.

0 commit comments

Comments
 (0)