Skip to content

Commit feac19a

Browse files
dmatlacksean-jc
authored andcommitted
KVM: x86/mmu: Remove function comments above clear_dirty_{gfn_range,pt_masked}()
Drop the comments above clear_dirty_gfn_range() and clear_dirty_pt_masked(), since each is word-for-word identical to the comment above their parent function. Leave the comment on the parent functions since they are APIs called by the KVM/x86 MMU. No functional change intended. Signed-off-by: David Matlack <dmatlack@google.com> Link: https://lore.kernel.org/r/20240315230541.1635322-3-dmatlack@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>
1 parent 2673dfb commit feac19a

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

arch/x86/kvm/mmu/tdp_mmu.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1558,13 +1558,6 @@ static bool tdp_mmu_need_write_protect(struct kvm_mmu_page *sp)
15581558
return kvm_mmu_page_ad_need_write_protect(sp) || !kvm_ad_enabled();
15591559
}
15601560

1561-
/*
1562-
* Clear the dirty status of all the SPTEs mapping GFNs in the memslot. If
1563-
* AD bits are enabled, this will involve clearing the dirty bit on each SPTE.
1564-
* If AD bits are not enabled, this will require clearing the writable bit on
1565-
* each SPTE. Returns true if an SPTE has been changed and the TLBs need to
1566-
* be flushed.
1567-
*/
15681561
static bool clear_dirty_gfn_range(struct kvm *kvm, struct kvm_mmu_page *root,
15691562
gfn_t start, gfn_t end)
15701563
{
@@ -1621,13 +1614,6 @@ bool kvm_tdp_mmu_clear_dirty_slot(struct kvm *kvm,
16211614
return spte_set;
16221615
}
16231616

1624-
/*
1625-
* Clears the dirty status of all the 4k SPTEs mapping GFNs for which a bit is
1626-
* set in mask, starting at gfn. The given memslot is expected to contain all
1627-
* the GFNs represented by set bits in the mask. If AD bits are enabled,
1628-
* clearing the dirty status will involve clearing the dirty bit on each SPTE
1629-
* or, if AD bits are not enabled, clearing the writable bit on each SPTE.
1630-
*/
16311617
static void clear_dirty_pt_masked(struct kvm *kvm, struct kvm_mmu_page *root,
16321618
gfn_t gfn, unsigned long mask, bool wrprot)
16331619
{

0 commit comments

Comments
 (0)