Skip to content

Commit fd46bc0

Browse files
damien-lemoalbjorn-helgaas
authored andcommitted
PCI: rockchip: Add missing fields descriptions for struct rockchip_pcie_ep
When compiling the Rockchip endpoint driver with -W=1, the following warnings can be seen in the output: drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'perst_irq' not described in 'rockchip_pcie_ep' drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'perst_asserted' not described in 'rockchip_pcie_ep' drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'link_up' not described in 'rockchip_pcie_ep' drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'link_training' not described in 'rockchip_pcie_ep' Fix these warnings by adding the missing field descriptions in struct rockchip_pcie_ep kernel-doc comment. Fixes: a7137cb ("PCI: rockchip-ep: Handle PERST# signal in EP mode") Fixes: bd6e61d ("PCI: rockchip-ep: Improve link training") Link: https://lore.kernel.org/r/20241216133404.540736-1-dlemoal@kernel.org Reported-by: Bjorn Helgaas <helgaas@kernel.org> Signed-off-by: Damien Le Moal <dlemoal@kernel.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
1 parent 40384c8 commit fd46bc0

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/pci/controller/pcie-rockchip-ep.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@
4040
* @irq_pci_fn: the latest PCI function that has updated the mapping of
4141
* the MSI/INTX IRQ dedicated outbound region.
4242
* @irq_pending: bitmask of asserted INTX IRQs.
43+
* @perst_irq: IRQ used for the PERST# signal.
44+
* @perst_asserted: True if the PERST# signal was asserted.
45+
* @link_up: True if the PCI link is up.
46+
* @link_training: Work item to execute PCI link training.
4347
*/
4448
struct rockchip_pcie_ep {
4549
struct rockchip_pcie rockchip;

0 commit comments

Comments
 (0)