Skip to content

Commit fa8805a

Browse files
committed
Merge branch 'pci/controller/qcom'
- Configure controller so MHI bus master clock will be switched off while in ASPM L1.x states (Manivannan Sadhasivam) - Add sa8775p DT binding and driver support (Mrinmay Sarkar) - Fix broken DT SDX65 "compatible" property (Krzysztof Kozlowski) * pci/controller/qcom: dt-bindings: PCI: qcom: Fix SDX65 compatible PCI: qcom: Add support for sa8775p SoC dt-bindings: PCI: qcom: Add sa8775p compatible PCI: qcom-ep: Switch MHI bus master clock off during L1SS
2 parents 26d7492 + 15d63a8 commit fa8805a

File tree

4 files changed

+37
-6
lines changed

4 files changed

+37
-6
lines changed

Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,13 @@ maintainers:
1111

1212
properties:
1313
compatible:
14-
enum:
15-
- qcom,sdx55-pcie-ep
16-
- qcom,sdx65-pcie-ep
17-
- qcom,sm8450-pcie-ep
14+
oneOf:
15+
- enum:
16+
- qcom,sdx55-pcie-ep
17+
- qcom,sm8450-pcie-ep
18+
- items:
19+
- const: qcom,sdx65-pcie-ep
20+
- const: qcom,sdx55-pcie-ep
1821

1922
reg:
2023
items:
@@ -110,7 +113,6 @@ allOf:
110113
contains:
111114
enum:
112115
- qcom,sdx55-pcie-ep
113-
- qcom,sdx65-pcie-ep
114116
then:
115117
properties:
116118
clocks:

Documentation/devicetree/bindings/pci/qcom,pcie.yaml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ properties:
2929
- qcom,pcie-msm8996
3030
- qcom,pcie-qcs404
3131
- qcom,pcie-sa8540p
32+
- qcom,pcie-sa8775p
3233
- qcom,pcie-sc7280
3334
- qcom,pcie-sc8180x
3435
- qcom,pcie-sc8280xp
@@ -211,6 +212,7 @@ allOf:
211212
compatible:
212213
contains:
213214
enum:
215+
- qcom,pcie-sa8775p
214216
- qcom,pcie-sc7280
215217
- qcom,pcie-sc8180x
216218
- qcom,pcie-sc8280xp
@@ -743,12 +745,37 @@ allOf:
743745
items:
744746
- const: pci # PCIe core reset
745747

748+
- if:
749+
properties:
750+
compatible:
751+
contains:
752+
enum:
753+
- qcom,pcie-sa8775p
754+
then:
755+
properties:
756+
clocks:
757+
minItems: 5
758+
maxItems: 5
759+
clock-names:
760+
items:
761+
- const: aux # Auxiliary clock
762+
- const: cfg # Configuration clock
763+
- const: bus_master # Master AXI clock
764+
- const: bus_slave # Slave AXI clock
765+
- const: slave_q2a # Slave Q2A clock
766+
resets:
767+
maxItems: 1
768+
reset-names:
769+
items:
770+
- const: pci # PCIe core reset
771+
746772
- if:
747773
properties:
748774
compatible:
749775
contains:
750776
enum:
751777
- qcom,pcie-sa8540p
778+
- qcom,pcie-sa8775p
752779
- qcom,pcie-sc8280xp
753780
then:
754781
required:
@@ -790,6 +817,7 @@ allOf:
790817
contains:
791818
enum:
792819
- qcom,pcie-msm8996
820+
- qcom,pcie-sa8775p
793821
- qcom,pcie-sc7280
794822
- qcom,pcie-sc8180x
795823
- qcom,pcie-sdm845

drivers/pci/controller/dwc/pcie-qcom-ep.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ static int qcom_pcie_perst_deassert(struct dw_pcie *pci)
415415
/* Gate Master AXI clock to MHI bus during L1SS */
416416
val = readl_relaxed(pcie_ep->parf + PARF_MHI_CLOCK_RESET_CTRL);
417417
val &= ~PARF_MSTR_AXI_CLK_EN;
418-
val = readl_relaxed(pcie_ep->parf + PARF_MHI_CLOCK_RESET_CTRL);
418+
writel_relaxed(val, pcie_ep->parf + PARF_MHI_CLOCK_RESET_CTRL);
419419

420420
dw_pcie_ep_init_notify(&pcie_ep->pci.ep);
421421

drivers/pci/controller/dwc/pcie-qcom.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1613,6 +1613,7 @@ static const struct of_device_id qcom_pcie_match[] = {
16131613
{ .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 },
16141614
{ .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 },
16151615
{ .compatible = "qcom,pcie-sa8540p", .data = &cfg_1_9_0 },
1616+
{ .compatible = "qcom,pcie-sa8775p", .data = &cfg_1_9_0},
16161617
{ .compatible = "qcom,pcie-sc7280", .data = &cfg_1_9_0 },
16171618
{ .compatible = "qcom,pcie-sc8180x", .data = &cfg_1_9_0 },
16181619
{ .compatible = "qcom,pcie-sc8280xp", .data = &cfg_1_9_0 },

0 commit comments

Comments
 (0)