Skip to content

Commit fa165e1

Browse files
Edward Creekuba-moo
authored andcommitted
sfc: don't unregister flow_indr if it was never registered
In efx_init_tc(), move the setting of efx->tc->up after the flow_indr_dev_register() call, so that if it fails, efx_fini_tc() won't call flow_indr_dev_unregister(). Fixes: 5b2e12d ("sfc: bind indirect blocks for TC offload on EF100") Suggested-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com> Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com> Link: https://lore.kernel.org/r/a81284d7013aba74005277bd81104e4cfbea3f6f.1692114888.git.ecree.xilinx@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 23d775f commit fa165e1

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/ethernet/sfc

1 file changed

+1
-1
lines changed

drivers/net/ethernet/sfc/tc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1657,10 +1657,10 @@ int efx_init_tc(struct efx_nic *efx)
16571657
rc = efx_tc_configure_fallback_acts_reps(efx);
16581658
if (rc)
16591659
return rc;
1660-
efx->tc->up = true;
16611660
rc = flow_indr_dev_register(efx_tc_indr_setup_cb, efx);
16621661
if (rc)
16631662
return rc;
1663+
efx->tc->up = true;
16641664
return 0;
16651665
}
16661666

0 commit comments

Comments
 (0)