Skip to content

Commit f9dbb99

Browse files
Zhang Zekunnmenon
authored andcommitted
soc: ti: Use devm_platform_ioremap_resource_byname simplify logic
platform_get_resource_byname() and devm_ioremap_resource() can be replaced by devm_platform_ioremap_resource_byname(), which can simplify the code logic a bit, No functional change here. Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> Reviewed-by: Dhruva Gole <d-gole@ti.com> Link: https://lore.kernel.org/r/20230809081523.26196-1-zhangzekun11@huawei.com Signed-off-by: Nishanth Menon <nm@ti.com>
1 parent e50a763 commit f9dbb99

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

drivers/soc/ti/k3-ringacc.c

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1368,7 +1368,6 @@ static int k3_ringacc_init(struct platform_device *pdev,
13681368
const struct soc_device_attribute *soc;
13691369
void __iomem *base_fifo, *base_rt;
13701370
struct device *dev = &pdev->dev;
1371-
struct resource *res;
13721371
int ret, i;
13731372

13741373
dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
@@ -1387,24 +1386,20 @@ static int k3_ringacc_init(struct platform_device *pdev,
13871386
ringacc->dma_ring_reset_quirk = soc_data->dma_ring_reset_quirk;
13881387
}
13891388

1390-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rt");
1391-
base_rt = devm_ioremap_resource(dev, res);
1389+
base_rt = devm_platform_ioremap_resource_byname(pdev, "rt");
13921390
if (IS_ERR(base_rt))
13931391
return PTR_ERR(base_rt);
13941392

1395-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "fifos");
1396-
base_fifo = devm_ioremap_resource(dev, res);
1393+
base_fifo = devm_platform_ioremap_resource_byname(pdev, "fifos");
13971394
if (IS_ERR(base_fifo))
13981395
return PTR_ERR(base_fifo);
13991396

1400-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "proxy_gcfg");
1401-
ringacc->proxy_gcfg = devm_ioremap_resource(dev, res);
1397+
ringacc->proxy_gcfg = devm_platform_ioremap_resource_byname(pdev, "proxy_gcfg");
14021398
if (IS_ERR(ringacc->proxy_gcfg))
14031399
return PTR_ERR(ringacc->proxy_gcfg);
14041400

1405-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
1406-
"proxy_target");
1407-
ringacc->proxy_target_base = devm_ioremap_resource(dev, res);
1401+
ringacc->proxy_target_base = devm_platform_ioremap_resource_byname(pdev,
1402+
"proxy_target");
14081403
if (IS_ERR(ringacc->proxy_target_base))
14091404
return PTR_ERR(ringacc->proxy_target_base);
14101405

@@ -1471,7 +1466,6 @@ struct k3_ringacc *k3_ringacc_dmarings_init(struct platform_device *pdev,
14711466
struct device *dev = &pdev->dev;
14721467
struct k3_ringacc *ringacc;
14731468
void __iomem *base_rt;
1474-
struct resource *res;
14751469
int i;
14761470

14771471
ringacc = devm_kzalloc(dev, sizeof(*ringacc), GFP_KERNEL);
@@ -1486,8 +1480,7 @@ struct k3_ringacc *k3_ringacc_dmarings_init(struct platform_device *pdev,
14861480

14871481
mutex_init(&ringacc->req_lock);
14881482

1489-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ringrt");
1490-
base_rt = devm_ioremap_resource(dev, res);
1483+
base_rt = devm_platform_ioremap_resource_byname(pdev, "ringrt");
14911484
if (IS_ERR(base_rt))
14921485
return ERR_CAST(base_rt);
14931486

0 commit comments

Comments
 (0)