Skip to content

Commit f9be5cb

Browse files
Ondrej Jirmansre
authored andcommitted
power: supply: ip5xxx: Fix integer overflow in current_now calculation
When current is larger than ~2A, the multiplication in current_now property overflows and the kernel reports invalid negative current value. Change the numerator and denominator while preserving their ratio to allow up to +-6A before the overflow. Fixes: 7585340 ("power: supply: Add a driver for Injoinic power bank ICs") Signed-off-by: Ondrej Jirman <megi@xff.cz> Reviewed-by: Samuel Holland <samuel@sholland.org> [use 149197/200 instead of 261095/350 as suggested by Samuel] Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
1 parent 883babd commit f9be5cb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/power/supply/ip5xxx_power.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ static int ip5xxx_battery_get_property(struct power_supply *psy,
352352
ret = ip5xxx_battery_read_adc(ip5xxx, IP5XXX_BATIADC_DAT0,
353353
IP5XXX_BATIADC_DAT1, &raw);
354354

355-
val->intval = DIV_ROUND_CLOSEST(raw * 745985, 1000);
355+
val->intval = DIV_ROUND_CLOSEST(raw * 149197, 200);
356356
return 0;
357357

358358
case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:

0 commit comments

Comments
 (0)