Skip to content

Commit f9733aa

Browse files
DerDakonRussell King (Oracle)
authored andcommitted
ARM: 9439/1: arm32: simplify ARM_MMU_KEEP usage
All current users need to add a KEEP() around the argument so the value is actually kept, which doesn't feel very natural and is prone to upcoming bugs as the name suggests that this macro alone already keeps things. Move that directly into the definition. Signed-off-by: Rolf Eike Beer <eb@emlix.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
1 parent 2014c95 commit f9733aa

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

arch/arm/include/asm/vmlinux.lds.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#endif
2020

2121
#ifdef CONFIG_MMU
22-
#define ARM_MMU_KEEP(x) x
22+
#define ARM_MMU_KEEP(x) KEEP(x)
2323
#define ARM_MMU_DISCARD(x)
2424
#else
2525
#define ARM_MMU_KEEP(x)

arch/arm/kernel/vmlinux-xip.lds.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ SECTIONS
6363
. = ALIGN(4);
6464
__ex_table : AT(ADDR(__ex_table) - LOAD_OFFSET) {
6565
__start___ex_table = .;
66-
ARM_MMU_KEEP(KEEP(*(__ex_table)))
66+
ARM_MMU_KEEP(*(__ex_table))
6767
__stop___ex_table = .;
6868
}
6969

arch/arm/kernel/vmlinux.lds.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ SECTIONS
7474
. = ALIGN(4);
7575
__ex_table : AT(ADDR(__ex_table) - LOAD_OFFSET) {
7676
__start___ex_table = .;
77-
ARM_MMU_KEEP(KEEP(*(__ex_table)))
77+
ARM_MMU_KEEP(*(__ex_table))
7878
__stop___ex_table = .;
7979
}
8080

0 commit comments

Comments
 (0)