Skip to content

Commit f83a96e

Browse files
Benjamin Gaignardbroonie
authored andcommitted
spi: mediatek: Avoid NULL pointer crash in interrupt
In some case, like after a transfer timeout, master->cur_msg pointer is NULL which led to a kernel crash when trying to use master->cur_msg->spi. mtk_spi_can_dma(), pointed by master->can_dma, doesn't use this parameter avoid the problem by setting NULL as second parameter. Fixes: a568231 ("spi: mediatek: Add spi bus for Mediatek MT8173") Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> Link: https://lore.kernel.org/r/20220131141708.888710-1-benjamin.gaignard@collabora.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 60b1e97 commit f83a96e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/spi/spi-mt65xx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ static irqreturn_t mtk_spi_interrupt(int irq, void *dev_id)
624624
else
625625
mdata->state = MTK_SPI_IDLE;
626626

627-
if (!master->can_dma(master, master->cur_msg->spi, trans)) {
627+
if (!master->can_dma(master, NULL, trans)) {
628628
if (trans->rx_buf) {
629629
cnt = mdata->xfer_len / 4;
630630
ioread32_rep(mdata->base + SPI_RX_DATA_REG,

0 commit comments

Comments
 (0)