Skip to content

Commit f72d965

Browse files
author
Steve French
committed
smb3: minor cleanup of session handling code
Minor cleanup of style issues found by checkpatch Reviewed-by: Bharath SM <bharathsm@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 19a4b9d commit f72d965

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

fs/smb/client/sess.c

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ cifs_chan_clear_in_reconnect(struct cifs_ses *ses,
105105
struct TCP_Server_Info *server)
106106
{
107107
unsigned int chan_index = cifs_ses_get_chan_index(ses, server);
108+
108109
if (chan_index == CIFS_INVAL_CHAN_INDEX)
109110
return;
110111

@@ -116,6 +117,7 @@ cifs_chan_in_reconnect(struct cifs_ses *ses,
116117
struct TCP_Server_Info *server)
117118
{
118119
unsigned int chan_index = cifs_ses_get_chan_index(ses, server);
120+
119121
if (chan_index == CIFS_INVAL_CHAN_INDEX)
120122
return true; /* err on the safer side */
121123

@@ -127,6 +129,7 @@ cifs_chan_set_need_reconnect(struct cifs_ses *ses,
127129
struct TCP_Server_Info *server)
128130
{
129131
unsigned int chan_index = cifs_ses_get_chan_index(ses, server);
132+
130133
if (chan_index == CIFS_INVAL_CHAN_INDEX)
131134
return;
132135

@@ -140,6 +143,7 @@ cifs_chan_clear_need_reconnect(struct cifs_ses *ses,
140143
struct TCP_Server_Info *server)
141144
{
142145
unsigned int chan_index = cifs_ses_get_chan_index(ses, server);
146+
143147
if (chan_index == CIFS_INVAL_CHAN_INDEX)
144148
return;
145149

@@ -153,6 +157,7 @@ cifs_chan_needs_reconnect(struct cifs_ses *ses,
153157
struct TCP_Server_Info *server)
154158
{
155159
unsigned int chan_index = cifs_ses_get_chan_index(ses, server);
160+
156161
if (chan_index == CIFS_INVAL_CHAN_INDEX)
157162
return true; /* err on the safer side */
158163

@@ -164,6 +169,7 @@ cifs_chan_is_iface_active(struct cifs_ses *ses,
164169
struct TCP_Server_Info *server)
165170
{
166171
unsigned int chan_index = cifs_ses_get_chan_index(ses, server);
172+
167173
if (chan_index == CIFS_INVAL_CHAN_INDEX)
168174
return true; /* err on the safer side */
169175

@@ -639,8 +645,7 @@ static __u32 cifs_ssetup_hdr(struct cifs_ses *ses,
639645

640646
/* Now no need to set SMBFLG_CASELESS or obsolete CANONICAL PATH */
641647

642-
/* BB verify whether signing required on neg or just on auth frame
643-
(and NTLM case) */
648+
/* BB verify whether signing required on neg or just auth frame (and NTLM case) */
644649

645650
capabilities = CAP_LARGE_FILES | CAP_NT_SMBS | CAP_LEVEL_II_OPLOCKS |
646651
CAP_LARGE_WRITE_X | CAP_LARGE_READ_X;
@@ -697,8 +702,10 @@ static void unicode_domain_string(char **pbcc_area, struct cifs_ses *ses,
697702

698703
/* copy domain */
699704
if (ses->domainName == NULL) {
700-
/* Sending null domain better than using a bogus domain name (as
701-
we did briefly in 2.6.18) since server will use its default */
705+
/*
706+
* Sending null domain better than using a bogus domain name (as
707+
* we did briefly in 2.6.18) since server will use its default
708+
*/
702709
*bcc_ptr = 0;
703710
*(bcc_ptr+1) = 0;
704711
bytes_ret = 0;
@@ -717,8 +724,7 @@ static void unicode_ssetup_strings(char **pbcc_area, struct cifs_ses *ses,
717724
char *bcc_ptr = *pbcc_area;
718725
int bytes_ret = 0;
719726

720-
/* BB FIXME add check that strings total less
721-
than 335 or will need to send them as arrays */
727+
/* BB FIXME add check that strings less than 335 or will need to send as arrays */
722728

723729
/* copy user */
724730
if (ses->user_name == NULL) {

0 commit comments

Comments
 (0)