Skip to content

Commit f69583d

Browse files
Uwe Kleine-Königgregkh
authored andcommitted
firmware: coreboot_table: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/d323e4f24bfab3ac1480933deb51e7c5cb025b09.1703693980.git.u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2595665 commit f69583d

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/firmware/google/coreboot_table.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,9 @@ static int __cb_dev_unregister(struct device *dev, void *dummy)
176176
return 0;
177177
}
178178

179-
static int coreboot_table_remove(struct platform_device *pdev)
179+
static void coreboot_table_remove(struct platform_device *pdev)
180180
{
181181
bus_for_each_dev(&coreboot_bus_type, NULL, NULL, __cb_dev_unregister);
182-
return 0;
183182
}
184183

185184
#ifdef CONFIG_ACPI
@@ -201,7 +200,7 @@ MODULE_DEVICE_TABLE(of, coreboot_of_match);
201200

202201
static struct platform_driver coreboot_table_driver = {
203202
.probe = coreboot_table_probe,
204-
.remove = coreboot_table_remove,
203+
.remove_new = coreboot_table_remove,
205204
.driver = {
206205
.name = "coreboot_table",
207206
.acpi_match_table = ACPI_PTR(cros_coreboot_acpi_match),

0 commit comments

Comments
 (0)