Skip to content

Commit f56b6db

Browse files
committed
drm/atomic-helper: Change parameter name of drm_atomic_helper_wait_for_flip_done()
drm_atomic_helper_wait_for_flip_done() will wait for pages flips on all CRTCs affected by a given commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-26-e71598f49c8f@kernel.org Signed-off-by: Maxime Ripard <mripard@kernel.org>
1 parent bc8ab44 commit f56b6db

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1728,7 +1728,7 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_vblanks);
17281728
/**
17291729
* drm_atomic_helper_wait_for_flip_done - wait for all page flips to be done
17301730
* @dev: DRM device
1731-
* @old_state: atomic state object with old state structures
1731+
* @state: atomic state object being committed
17321732
*
17331733
* Helper to, after atomic commit, wait for page flips on all affected
17341734
* crtcs (ie. before cleaning up old framebuffers using
@@ -1741,16 +1741,16 @@ EXPORT_SYMBOL(drm_atomic_helper_wait_for_vblanks);
17411741
* initialized using drm_atomic_helper_setup_commit().
17421742
*/
17431743
void drm_atomic_helper_wait_for_flip_done(struct drm_device *dev,
1744-
struct drm_atomic_state *old_state)
1744+
struct drm_atomic_state *state)
17451745
{
17461746
struct drm_crtc *crtc;
17471747
int i;
17481748

17491749
for (i = 0; i < dev->mode_config.num_crtc; i++) {
1750-
struct drm_crtc_commit *commit = old_state->crtcs[i].commit;
1750+
struct drm_crtc_commit *commit = state->crtcs[i].commit;
17511751
int ret;
17521752

1753-
crtc = old_state->crtcs[i].ptr;
1753+
crtc = state->crtcs[i].ptr;
17541754

17551755
if (!crtc || !commit)
17561756
continue;
@@ -1761,8 +1761,8 @@ void drm_atomic_helper_wait_for_flip_done(struct drm_device *dev,
17611761
crtc->base.id, crtc->name);
17621762
}
17631763

1764-
if (old_state->fake_commit)
1765-
complete_all(&old_state->fake_commit->flip_done);
1764+
if (state->fake_commit)
1765+
complete_all(&state->fake_commit->flip_done);
17661766
}
17671767
EXPORT_SYMBOL(drm_atomic_helper_wait_for_flip_done);
17681768

0 commit comments

Comments
 (0)