Skip to content

Commit f40a33f

Browse files
committed
Merge tag 'trace-v5.17-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
Pull tracing fixes from Steven Rostedt: - Fix sorting on old "cpu" value in histograms - Fix return value of __setup() boot parameter handlers * tag 'trace-v5.17-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace: tracing: Fix return value of __setup handlers tracing/histogram: Fix sorting on old "cpu" value
2 parents dcde98d + 1d02b44 commit f40a33f

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

kernel/trace/trace.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ static char trace_boot_options_buf[MAX_TRACER_SIZE] __initdata;
235235
static int __init set_trace_boot_options(char *str)
236236
{
237237
strlcpy(trace_boot_options_buf, str, MAX_TRACER_SIZE);
238-
return 0;
238+
return 1;
239239
}
240240
__setup("trace_options=", set_trace_boot_options);
241241

@@ -246,7 +246,7 @@ static int __init set_trace_boot_clock(char *str)
246246
{
247247
strlcpy(trace_boot_clock_buf, str, MAX_TRACER_SIZE);
248248
trace_boot_clock = trace_boot_clock_buf;
249-
return 0;
249+
return 1;
250250
}
251251
__setup("trace_clock=", set_trace_boot_clock);
252252

kernel/trace/trace_events_hist.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2289,9 +2289,9 @@ parse_field(struct hist_trigger_data *hist_data, struct trace_event_file *file,
22892289
/*
22902290
* For backward compatibility, if field_name
22912291
* was "cpu", then we treat this the same as
2292-
* common_cpu.
2292+
* common_cpu. This also works for "CPU".
22932293
*/
2294-
if (strcmp(field_name, "cpu") == 0) {
2294+
if (field && field->filter_type == FILTER_CPU) {
22952295
*flags |= HIST_FIELD_FL_CPU;
22962296
} else {
22972297
hist_err(tr, HIST_ERR_FIELD_NOT_FOUND,
@@ -4832,7 +4832,7 @@ static int create_tracing_map_fields(struct hist_trigger_data *hist_data)
48324832

48334833
if (hist_field->flags & HIST_FIELD_FL_STACKTRACE)
48344834
cmp_fn = tracing_map_cmp_none;
4835-
else if (!field)
4835+
else if (!field || hist_field->flags & HIST_FIELD_FL_CPU)
48364836
cmp_fn = tracing_map_cmp_num(hist_field->size,
48374837
hist_field->is_signed);
48384838
else if (is_string_field(field))

kernel/trace/trace_kprobe.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ static int __init set_kprobe_boot_events(char *str)
3232
strlcpy(kprobe_boot_events_buf, str, COMMAND_LINE_SIZE);
3333
disable_tracing_selftest("running kprobe events");
3434

35-
return 0;
35+
return 1;
3636
}
3737
__setup("kprobe_event=", set_kprobe_boot_events);
3838

0 commit comments

Comments
 (0)