Skip to content

Commit f393592

Browse files
committed
Merge tag 'arc-5.18-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc
Pull ARC fixes from Vineet Gupta: - Assorted fixes * tag 'arc-5.18-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc: ARC: remove redundant READ_ONCE() in cmpxchg loop ARC: atomic: cleanup atomic-llsc definitions arc: drop definitions of pgd_index() and pgd_offset{, _k}() entirely ARC: dts: align SPI NOR node name with dtschema ARC: Remove a redundant memset() ARC: fix typos in comments ARC: entry: fix syscall_trace_exit argument
2 parents 6fc2586 + c6ed4d8 commit f393592

File tree

9 files changed

+24
-27
lines changed

9 files changed

+24
-27
lines changed

arch/arc/boot/dts/hsdk.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@
275275
cs-gpios = <&creg_gpio 0 GPIO_ACTIVE_LOW>,
276276
<&creg_gpio 1 GPIO_ACTIVE_LOW>;
277277

278-
spi-flash@0 {
278+
flash@0 {
279279
compatible = "sst26wf016b", "jedec,spi-nor";
280280
reg = <0>;
281281
#address-cells = <1>;

arch/arc/include/asm/atomic-llsc.h

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
#define arch_atomic_set(v, i) WRITE_ONCE(((v)->counter), (i))
77

8-
#define ATOMIC_OP(op, c_op, asm_op) \
8+
#define ATOMIC_OP(op, asm_op) \
99
static inline void arch_atomic_##op(int i, atomic_t *v) \
1010
{ \
1111
unsigned int val; \
@@ -21,7 +21,7 @@ static inline void arch_atomic_##op(int i, atomic_t *v) \
2121
: "cc"); \
2222
} \
2323

24-
#define ATOMIC_OP_RETURN(op, c_op, asm_op) \
24+
#define ATOMIC_OP_RETURN(op, asm_op) \
2525
static inline int arch_atomic_##op##_return_relaxed(int i, atomic_t *v) \
2626
{ \
2727
unsigned int val; \
@@ -42,7 +42,7 @@ static inline int arch_atomic_##op##_return_relaxed(int i, atomic_t *v) \
4242
#define arch_atomic_add_return_relaxed arch_atomic_add_return_relaxed
4343
#define arch_atomic_sub_return_relaxed arch_atomic_sub_return_relaxed
4444

45-
#define ATOMIC_FETCH_OP(op, c_op, asm_op) \
45+
#define ATOMIC_FETCH_OP(op, asm_op) \
4646
static inline int arch_atomic_fetch_##op##_relaxed(int i, atomic_t *v) \
4747
{ \
4848
unsigned int val, orig; \
@@ -69,23 +69,23 @@ static inline int arch_atomic_fetch_##op##_relaxed(int i, atomic_t *v) \
6969
#define arch_atomic_fetch_or_relaxed arch_atomic_fetch_or_relaxed
7070
#define arch_atomic_fetch_xor_relaxed arch_atomic_fetch_xor_relaxed
7171

72-
#define ATOMIC_OPS(op, c_op, asm_op) \
73-
ATOMIC_OP(op, c_op, asm_op) \
74-
ATOMIC_OP_RETURN(op, c_op, asm_op) \
75-
ATOMIC_FETCH_OP(op, c_op, asm_op)
72+
#define ATOMIC_OPS(op, asm_op) \
73+
ATOMIC_OP(op, asm_op) \
74+
ATOMIC_OP_RETURN(op, asm_op) \
75+
ATOMIC_FETCH_OP(op, asm_op)
7676

77-
ATOMIC_OPS(add, +=, add)
78-
ATOMIC_OPS(sub, -=, sub)
77+
ATOMIC_OPS(add, add)
78+
ATOMIC_OPS(sub, sub)
7979

8080
#undef ATOMIC_OPS
81-
#define ATOMIC_OPS(op, c_op, asm_op) \
82-
ATOMIC_OP(op, c_op, asm_op) \
83-
ATOMIC_FETCH_OP(op, c_op, asm_op)
81+
#define ATOMIC_OPS(op, asm_op) \
82+
ATOMIC_OP(op, asm_op) \
83+
ATOMIC_FETCH_OP(op, asm_op)
8484

85-
ATOMIC_OPS(and, &=, and)
86-
ATOMIC_OPS(andnot, &= ~, bic)
87-
ATOMIC_OPS(or, |=, or)
88-
ATOMIC_OPS(xor, ^=, xor)
85+
ATOMIC_OPS(and, and)
86+
ATOMIC_OPS(andnot, bic)
87+
ATOMIC_OPS(or, or)
88+
ATOMIC_OPS(xor, xor)
8989

9090
#define arch_atomic_andnot arch_atomic_andnot
9191

arch/arc/include/asm/pgtable-levels.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,6 @@
9898
/*
9999
* 1st level paging: pgd
100100
*/
101-
#define pgd_index(addr) ((addr) >> PGDIR_SHIFT)
102-
#define pgd_offset(mm, addr) (((mm)->pgd) + pgd_index(addr))
103-
#define pgd_offset_k(addr) pgd_offset(&init_mm, addr)
104101
#define pgd_ERROR(e) \
105102
pr_crit("%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pgd_val(e))
106103

arch/arc/kernel/disasm.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ void __kprobes disasm_instr(unsigned long addr, struct disasm_state *state,
366366
case op_SP: /* LD_S|LDB_S b,[sp,u7], ST_S|STB_S b,[sp,u7] */
367367
/* note: we are ignoring possibility of:
368368
* ADD_S, SUB_S, PUSH_S, POP_S as these should not
369-
* cause unaliged exception anyway */
369+
* cause unaligned exception anyway */
370370
state->write = BITS(state->words[0], 6, 6);
371371
state->zz = BITS(state->words[0], 5, 5);
372372
if (state->zz)
@@ -503,7 +503,6 @@ int __kprobes disasm_next_pc(unsigned long pc, struct pt_regs *regs,
503503
{
504504
struct disasm_state instr;
505505

506-
memset(&instr, 0, sizeof(struct disasm_state));
507506
disasm_instr(pc, &instr, 0, regs, cregs);
508507

509508
*next_pc = pc + instr.instr_len;

arch/arc/kernel/entry.S

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ tracesys_exit:
196196
st r0, [sp, PT_r0] ; sys call return value in pt_regs
197197

198198
;POST Sys Call Ptrace Hook
199+
mov r0, sp ; pt_regs needed
199200
bl @syscall_trace_exit
200201
b ret_from_exception ; NOT ret_from_system_call at is saves r0 which
201202
; we'd done before calling post hook above

arch/arc/kernel/signal.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ setup_rt_frame(struct ksignal *ksig, sigset_t *set, struct pt_regs *regs)
319319
regs->ret = (unsigned long)ksig->ka.sa.sa_handler;
320320

321321
/*
322-
* handler returns using sigreturn stub provided already by userpsace
322+
* handler returns using sigreturn stub provided already by userspace
323323
* If not, nuke the process right away
324324
*/
325325
if(!(ksig->ka.sa.sa_flags & SA_RESTORER))

arch/arc/kernel/smp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ EXPORT_SYMBOL_GPL(smp_atomic_ops_lock);
3535

3636
struct plat_smp_ops __weak plat_smp_ops;
3737

38-
/* XXX: per cpu ? Only needed once in early seconday boot */
38+
/* XXX: per cpu ? Only needed once in early secondary boot */
3939
struct task_struct *secondary_idle_tsk;
4040

4141
/* Called from start_kernel */
@@ -274,7 +274,7 @@ static void ipi_send_msg_one(int cpu, enum ipi_msg_type msg)
274274
* and read back old value
275275
*/
276276
do {
277-
new = old = READ_ONCE(*ipi_data_ptr);
277+
new = old = *ipi_data_ptr;
278278
new |= 1U << msg;
279279
} while (cmpxchg(ipi_data_ptr, old, new) != old);
280280

arch/arc/kernel/unaligned.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ int misaligned_fixup(unsigned long address, struct pt_regs *regs,
237237
if (state.fault)
238238
goto fault;
239239

240-
/* clear any remanants of delay slot */
240+
/* clear any remnants of delay slot */
241241
if (delay_mode(regs)) {
242242
regs->ret = regs->bta & ~1U;
243243
regs->status32 &= ~STATUS_DE_MASK;

arch/arc/mm/cache.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ static inline void __before_dc_op(const int op)
401401
{
402402
if (op == OP_FLUSH_N_INV) {
403403
/* Dcache provides 2 cmd: FLUSH or INV
404-
* INV inturn has sub-modes: DISCARD or FLUSH-BEFORE
404+
* INV in turn has sub-modes: DISCARD or FLUSH-BEFORE
405405
* flush-n-inv is achieved by INV cmd but with IM=1
406406
* So toggle INV sub-mode depending on op request and default
407407
*/

0 commit comments

Comments
 (0)