Skip to content

Commit f32e8c8

Browse files
superm1Jiri Kosina
authored andcommitted
HID: amd_sfh: Avoid clearing reports for SRA sensor
SRA sensor doesn't allocate any memory for reports. Skip trying to clear memory for that sensor in cleanup path. Suggested-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com> Signed-off-by: Jiri Kosina <jkosina@suse.com>
1 parent 0cc2eff commit f32e8c8

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,9 @@ static int amd_sfh_hid_client_deinit(struct amd_mp2_dev *privdata)
8383
case ALS_IDX:
8484
privdata->dev_en.is_als_present = false;
8585
break;
86+
case SRA_IDX:
87+
privdata->dev_en.is_sra_present = false;
88+
break;
8689
}
8790

8891
if (cl_data->sensor_sts[i] == SENSOR_ENABLED) {
@@ -237,6 +240,8 @@ static int amd_sfh1_1_hid_client_init(struct amd_mp2_dev *privdata)
237240
cleanup:
238241
amd_sfh_hid_client_deinit(privdata);
239242
for (i = 0; i < cl_data->num_hid_devices; i++) {
243+
if (cl_data->sensor_idx[i] == SRA_IDX)
244+
continue;
240245
devm_kfree(dev, cl_data->feature_report[i]);
241246
devm_kfree(dev, in_data->input_report[i]);
242247
devm_kfree(dev, cl_data->report_descr[i]);

0 commit comments

Comments
 (0)