Skip to content

Commit f2052a4

Browse files
petegriffinkrzk
authored andcommitted
clk: samsung: gs101: fix synchronous external abort in samsung_clk_save()
EARLY_WAKEUP_SW_TRIG_*_SET and EARLY_WAKEUP_SW_TRIG_*_CLEAR registers are only writeable. Attempting to read these registers during samsung_clk_save() causes a synchronous external abort. Remove these 8 registers from cmu_top_clk_regs[] array so that system suspend gets further. Note: the code path can be exercised using the following command: echo mem > /sys/power/state Fixes: 2c597bb ("clk: samsung: clk-gs101: Add cmu_top, cmu_misc and cmu_apm support") Signed-off-by: Peter Griffin <peter.griffin@linaro.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250303-clk-suspend-fix-v1-1-c2edaf66260f@linaro.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
1 parent 2014c95 commit f2052a4

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/clk/samsung/clk-gs101.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -382,17 +382,9 @@ static const unsigned long cmu_top_clk_regs[] __initconst = {
382382
EARLY_WAKEUP_DPU_DEST,
383383
EARLY_WAKEUP_CSIS_DEST,
384384
EARLY_WAKEUP_SW_TRIG_APM,
385-
EARLY_WAKEUP_SW_TRIG_APM_SET,
386-
EARLY_WAKEUP_SW_TRIG_APM_CLEAR,
387385
EARLY_WAKEUP_SW_TRIG_CLUSTER0,
388-
EARLY_WAKEUP_SW_TRIG_CLUSTER0_SET,
389-
EARLY_WAKEUP_SW_TRIG_CLUSTER0_CLEAR,
390386
EARLY_WAKEUP_SW_TRIG_DPU,
391-
EARLY_WAKEUP_SW_TRIG_DPU_SET,
392-
EARLY_WAKEUP_SW_TRIG_DPU_CLEAR,
393387
EARLY_WAKEUP_SW_TRIG_CSIS,
394-
EARLY_WAKEUP_SW_TRIG_CSIS_SET,
395-
EARLY_WAKEUP_SW_TRIG_CSIS_CLEAR,
396388
CLK_CON_MUX_MUX_CLKCMU_BO_BUS,
397389
CLK_CON_MUX_MUX_CLKCMU_BUS0_BUS,
398390
CLK_CON_MUX_MUX_CLKCMU_BUS1_BUS,

0 commit comments

Comments
 (0)