Skip to content

Commit efa97ae

Browse files
Liu YingShawn Guo
authored andcommitted
arm64: dts: imx8mm-evk: Fix hdmi@3d node
The hdmi@3d node's compatible string is "adi,adv7535" instead of "adi,adv7533" or "adi,adv751*". Fix the hdmi@3d node by means of: * Use default register addresses for "cec", "edid" and "packet", because there is no need to use a non-default address map. * Add missing interrupt related properties. * Drop "adi,input-*" properties which are only valid for adv751*. * Add VDDEXT_3V3 fixed regulator * Add "*-supply" properties, since most are required. * Fix label names - s/adv7533/adv7535/. Fixes: a27335b ("arm64: dts: imx8mm-evk: Add HDMI support") Signed-off-by: Liu Ying <victor.liu@nxp.com> Tested-by: Fabio Estevam <festevam@gmail.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
1 parent 9d1e827 commit efa97ae

File tree

1 file changed

+20
-12
lines changed

1 file changed

+20
-12
lines changed

arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
port {
2828
hdmi_connector_in: endpoint {
29-
remote-endpoint = <&adv7533_out>;
29+
remote-endpoint = <&adv7535_out>;
3030
};
3131
};
3232
};
@@ -72,6 +72,13 @@
7272
enable-active-high;
7373
};
7474

75+
reg_vddext_3v3: regulator-vddext-3v3 {
76+
compatible = "regulator-fixed";
77+
regulator-name = "VDDEXT_3V3";
78+
regulator-min-microvolt = <3300000>;
79+
regulator-max-microvolt = <3300000>;
80+
};
81+
7582
backlight: backlight {
7683
compatible = "pwm-backlight";
7784
pwms = <&pwm1 0 5000000 0>;
@@ -317,15 +324,16 @@
317324

318325
hdmi@3d {
319326
compatible = "adi,adv7535";
320-
reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
321-
reg-names = "main", "cec", "edid", "packet";
327+
reg = <0x3d>;
328+
interrupt-parent = <&gpio1>;
329+
interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
322330
adi,dsi-lanes = <4>;
323-
324-
adi,input-depth = <8>;
325-
adi,input-colorspace = "rgb";
326-
adi,input-clock = "1x";
327-
adi,input-style = <1>;
328-
adi,input-justification = "evenly";
331+
avdd-supply = <&buck5_reg>;
332+
dvdd-supply = <&buck5_reg>;
333+
pvdd-supply = <&buck5_reg>;
334+
a2vdd-supply = <&buck5_reg>;
335+
v3p3-supply = <&reg_vddext_3v3>;
336+
v1p2-supply = <&buck5_reg>;
329337

330338
ports {
331339
#address-cells = <1>;
@@ -334,15 +342,15 @@
334342
port@0 {
335343
reg = <0>;
336344

337-
adv7533_in: endpoint {
345+
adv7535_in: endpoint {
338346
remote-endpoint = <&dsi_out>;
339347
};
340348
};
341349

342350
port@1 {
343351
reg = <1>;
344352

345-
adv7533_out: endpoint {
353+
adv7535_out: endpoint {
346354
remote-endpoint = <&hdmi_connector_in>;
347355
};
348356
};
@@ -448,7 +456,7 @@
448456
reg = <1>;
449457

450458
dsi_out: endpoint {
451-
remote-endpoint = <&adv7533_in>;
459+
remote-endpoint = <&adv7535_in>;
452460
data-lanes = <1 2 3 4>;
453461
};
454462
};

0 commit comments

Comments
 (0)