PCI: imx6: Deassert apps_reset in imx_pcie_deassert_core_reset()

Richard Zhu · bjorn-helgaas · commit ef61c7d8d032 · 2025-01-16T14:29:38.000-06:00
Since the apps_reset is asserted in imx_pcie_assert_core_reset(), it should be deasserted in imx_pcie_deassert_core_reset(). Fixes: 9b3fe67 ("PCI: imx6: Add code to support i.MX7D") Link: https://lore.kernel.org/r/20241126075702.4099164-6-hongxing.zhu@nxp.com Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Frank Li <Frank.Li@nxp.com>
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
@@ -777,6 +777,7 @@ static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie)
 static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie)
 {
 	reset_control_deassert(imx_pcie->pciephy_reset);
+	reset_control_deassert(imx_pcie->apps_reset);
 
 	if (imx_pcie->drvdata->core_reset)
 		imx_pcie->drvdata->core_reset(imx_pcie, false);

Original file line number	Diff line number	Diff line change
`@@ -777,6 +777,7 @@ static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie)`
`777`	`777`	`static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie)`
`778`	`778`	`{`
`779`	`779`	`reset_control_deassert(imx_pcie->pciephy_reset);`
	`780`	`+ reset_control_deassert(imx_pcie->apps_reset);`
`780`	`781`
`781`	`782`	`if (imx_pcie->drvdata->core_reset)`
`782`	`783`	`imx_pcie->drvdata->core_reset(imx_pcie, false);`