clk: socfpga: arria10: Optimize local variables in clk_pll_recalc_rate()

toblux · Dinh Nguyen · commit ee46245564a8 · 2024-12-16T18:22:00.000-06:00
Since readl() returns a u32, the local variable reg can also have the
data type u32. Furthermore, divf and divq are derived from reg and can
also be a u32.

Since do_div() casts the divisor to u32 anyway, changing the data type
of divq to u32 also removes the following Coccinelle/coccicheck warning
reported by do_div.cocci:

  WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead

Compile-tested only.

Signed-off-by: Thorsten Blum &lt;thorsten.blum@linux.dev&gt;
Signed-off-by: Dinh Nguyen &lt;dinguyen@kernel.org&gt;
diff --git a/drivers/clk/socfpga/clk-pll-a10.c b/drivers/clk/socfpga/clk-pll-a10.c
@@ -35,7 +35,7 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hwclk,
 					 unsigned long parent_rate)
 {
 	struct socfpga_pll *socfpgaclk = to_socfpga_clk(hwclk);
-	unsigned long divf, divq, reg;
+	u32 divf, divq, reg;
 	unsigned long long vco_freq;
 
 	/* read VCO1 reg for numerator and denominator */

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hwclk,`
`35`	`35`	`unsigned long parent_rate)`
`36`	`36`	`{`
`37`	`37`	`struct socfpga_pll *socfpgaclk = to_socfpga_clk(hwclk);`
`38`		`- unsigned long divf, divq, reg;`
	`38`	`+ u32 divf, divq, reg;`
`39`	`39`	`unsigned long long vco_freq;`
`40`	`40`
`41`	`41`	`/* read VCO1 reg for numerator and denominator */`