Skip to content

Commit ec8ffff

Browse files
Robert Richterdjbw
authored andcommitted
cxl/pci: Rename DOE mailbox handle to doe_mb
Trivial variable rename for the DOE mailbox handle from cdat_doe to doe_mb. The variable name cdat_doe is too ambiguous, use doe_mb that is commonly used for the mailbox. Signed-off-by: Robert Richter <rrichter@amd.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Link: https://lore.kernel.org/r/20240216155844.406996-2-rrichter@amd.com Signed-off-by: Dan Williams <dan.j.williams@intel.com>
1 parent d206a76 commit ec8ffff

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

drivers/cxl/core/pci.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -518,14 +518,14 @@ EXPORT_SYMBOL_NS_GPL(cxl_hdm_decode_init, CXL);
518518
FIELD_PREP(CXL_DOE_TABLE_ACCESS_ENTRY_HANDLE, (entry_handle)))
519519

520520
static int cxl_cdat_get_length(struct device *dev,
521-
struct pci_doe_mb *cdat_doe,
521+
struct pci_doe_mb *doe_mb,
522522
size_t *length)
523523
{
524524
__le32 request = CDAT_DOE_REQ(0);
525525
__le32 response[2];
526526
int rc;
527527

528-
rc = pci_doe(cdat_doe, PCI_DVSEC_VENDOR_ID_CXL,
528+
rc = pci_doe(doe_mb, PCI_DVSEC_VENDOR_ID_CXL,
529529
CXL_DOE_PROTOCOL_TABLE_ACCESS,
530530
&request, sizeof(request),
531531
&response, sizeof(response));
@@ -543,7 +543,7 @@ static int cxl_cdat_get_length(struct device *dev,
543543
}
544544

545545
static int cxl_cdat_read_table(struct device *dev,
546-
struct pci_doe_mb *cdat_doe,
546+
struct pci_doe_mb *doe_mb,
547547
void *cdat_table, size_t *cdat_length)
548548
{
549549
size_t length = *cdat_length + sizeof(__le32);
@@ -557,7 +557,7 @@ static int cxl_cdat_read_table(struct device *dev,
557557
size_t entry_dw;
558558
int rc;
559559

560-
rc = pci_doe(cdat_doe, PCI_DVSEC_VENDOR_ID_CXL,
560+
rc = pci_doe(doe_mb, PCI_DVSEC_VENDOR_ID_CXL,
561561
CXL_DOE_PROTOCOL_TABLE_ACCESS,
562562
&request, sizeof(request),
563563
data, length);
@@ -617,7 +617,7 @@ void read_cdat_data(struct cxl_port *port)
617617
{
618618
struct device *uport = port->uport_dev;
619619
struct device *dev = &port->dev;
620-
struct pci_doe_mb *cdat_doe;
620+
struct pci_doe_mb *doe_mb;
621621
struct pci_dev *pdev = NULL;
622622
struct cxl_memdev *cxlmd;
623623
size_t cdat_length;
@@ -638,16 +638,16 @@ void read_cdat_data(struct cxl_port *port)
638638
if (!pdev)
639639
return;
640640

641-
cdat_doe = pci_find_doe_mailbox(pdev, PCI_DVSEC_VENDOR_ID_CXL,
642-
CXL_DOE_PROTOCOL_TABLE_ACCESS);
643-
if (!cdat_doe) {
641+
doe_mb = pci_find_doe_mailbox(pdev, PCI_DVSEC_VENDOR_ID_CXL,
642+
CXL_DOE_PROTOCOL_TABLE_ACCESS);
643+
if (!doe_mb) {
644644
dev_dbg(dev, "No CDAT mailbox\n");
645645
return;
646646
}
647647

648648
port->cdat_available = true;
649649

650-
if (cxl_cdat_get_length(dev, cdat_doe, &cdat_length)) {
650+
if (cxl_cdat_get_length(dev, doe_mb, &cdat_length)) {
651651
dev_dbg(dev, "No CDAT length\n");
652652
return;
653653
}
@@ -656,7 +656,7 @@ void read_cdat_data(struct cxl_port *port)
656656
if (!cdat_buf)
657657
return;
658658

659-
rc = cxl_cdat_read_table(dev, cdat_doe, cdat_buf, &cdat_length);
659+
rc = cxl_cdat_read_table(dev, doe_mb, cdat_buf, &cdat_length);
660660
if (rc)
661661
goto err;
662662

0 commit comments

Comments
 (0)