Skip to content

Commit ec1b908

Browse files
Mikhail Kobukdavem330
authored andcommitted
ethernet: tg3: remove unreachable code
'tp->irq_max' value is either 1 [L16336] or 5 [L16354], as indicated in tg3_get_invariants(). Therefore, 'i' can't exceed 4 in tg3_init_one() that makes (i <= 4) always true. Moreover, 'intmbx' value set at the last iteration is not used later in it's scope. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 78f90dc ("tg3: Move napi_add calls below tg3_get_invariants") Signed-off-by: Mikhail Kobuk <m.kobuk@ispras.ru> Reviewed-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Reviewed-by: Simon Horman <horms@kernel.org> Reviewed-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 977ad86 commit ec1b908

File tree

1 file changed

+1
-4
lines changed
  • drivers/net/ethernet/broadcom

1 file changed

+1
-4
lines changed

drivers/net/ethernet/broadcom/tg3.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17795,10 +17795,7 @@ static int tg3_init_one(struct pci_dev *pdev,
1779517795
tnapi->tx_pending = TG3_DEF_TX_RING_PENDING;
1779617796

1779717797
tnapi->int_mbox = intmbx;
17798-
if (i <= 4)
17799-
intmbx += 0x8;
17800-
else
17801-
intmbx += 0x4;
17798+
intmbx += 0x8;
1780217799

1780317800
tnapi->consmbox = rcvmbx;
1780417801
tnapi->prodmbox = sndmbx;

0 commit comments

Comments
 (0)