Skip to content

Commit eb1dd15

Browse files
makelinuxhtejun
authored andcommitted
cgroup/cpuset: Remove stale text
Task's cpuset pointer was removed by commit 8793d85 ("Task Control Groups: make cpusets a client of cgroups") Paragraph "The task_lock() exception ...." was removed by commit 2df167a ("cgroups: update comments in cpuset.c") Remove stale text: We also require taking task_lock() when dereferencing a task's cpuset pointer. See "The task_lock() exception", at the end of this comment. Accessing a task's cpuset should be done in accordance with the guidelines for accessing subsystem state in kernel/cgroup.c and reformat. Co-developed-by: Michal Koutný <mkoutny@suse.com> Co-developed-by: Waiman Long <longman@redhat.com> Signed-off-by: Costa Shulyupin <costa.shul@redhat.com> Acked-by: Waiman Long <longman@redhat.com> Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent f92f474 commit eb1dd15

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

kernel/cgroup/cpuset.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,8 @@ static struct cpuset top_cpuset = {
197197

198198
/*
199199
* There are two global locks guarding cpuset structures - cpuset_mutex and
200-
* callback_lock. We also require taking task_lock() when dereferencing a
201-
* task's cpuset pointer. See "The task_lock() exception", at the end of this
202-
* comment. The cpuset code uses only cpuset_mutex. Other kernel subsystems
203-
* can use cpuset_lock()/cpuset_unlock() to prevent change to cpuset
200+
* callback_lock. The cpuset code uses only cpuset_mutex. Other kernel
201+
* subsystems can use cpuset_lock()/cpuset_unlock() to prevent change to cpuset
204202
* structures. Note that cpuset_mutex needs to be a mutex as it is used in
205203
* paths that rely on priority inheritance (e.g. scheduler - on RT) for
206204
* correctness.
@@ -229,9 +227,6 @@ static struct cpuset top_cpuset = {
229227
* The cpuset_common_seq_show() handlers only hold callback_lock across
230228
* small pieces of code, such as when reading out possibly multi-word
231229
* cpumasks and nodemasks.
232-
*
233-
* Accessing a task's cpuset should be done in accordance with the
234-
* guidelines for accessing subsystem state in kernel/cgroup.c
235230
*/
236231

237232
static DEFINE_MUTEX(cpuset_mutex);

0 commit comments

Comments
 (0)