Skip to content

Commit ea2cb26

Browse files
morimotobroonie
authored andcommitted
ASoC: audio-graph-card2: add comment for format property
We don't need to have "format" property on DT any more if CPU/Codec driver has .auto_selectable_formats settings on snd_soc_dai_ops. The sample dtsi doesn't have it. To avoid user confusion, this patch indicates it on comment. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/87edjuzk2p.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 014ee06 commit ea2cb26

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

sound/soc/generic/audio-graph-card2-custom-sample.dtsi

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@
3434
* ...
3535
* };
3636
*
37+
*
38+
* Below sample doesn't use "format" property,
39+
* because test-component driver (test-cpu/test-codec) is supporting
40+
* snd_soc_dai_ops :: .auto_selectable_formats.
41+
* see
42+
* snd_soc_runtime_get_dai_fmt()
43+
* linux/sound/soc/generic/test-component.c :: test_dai_formats
3744
*/
3845
/ {
3946
/*

sound/soc/generic/audio-graph-card2.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,18 @@
4747
see
4848
graph_parse_daifmt().
4949
50+
"format" property is no longer needed on DT if both CPU/Codec drivers are
51+
supporting snd_soc_dai_ops :: .auto_selectable_formats.
52+
see
53+
snd_soc_runtime_get_dai_fmt()
54+
55+
sample driver
56+
linux/sound/soc/sh/rcar/core.c
57+
linux/sound/soc/codecs/ak4613.c
58+
linux/sound/soc/codecs/pcm3168a.c
59+
linux/sound/soc/soc-utils.c
60+
linux/sound/soc/generic/test-component.c
61+
5062
************************************
5163
Normal Audio-Graph
5264
************************************

0 commit comments

Comments
 (0)