Skip to content

Commit e96fe28

Browse files
iveceraanguy11
authored andcommitted
i40e: Do not call devlink_port_type_clear()
Do not call devlink_port_type_clear() prior devlink port unregister and let devlink core to take care about it. Reproducer: [root@host ~]# rmmod i40e [ 4539.964699] i40e 0000:02:00.0: devlink port type for port 0 cleared without a software interface reference, device type not supported by the kernel? [ 4540.319811] i40e 0000:02:00.1: devlink port type for port 1 cleared without a software interface reference, device type not supported by the kernel? Fixes: 9e479d6 ("i40e: Add initial devlink support") Signed-off-by: Ivan Vecera <ivecera@redhat.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent c1ed833 commit e96fe28

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/ethernet/intel/i40e/i40e_devlink.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,5 @@ int i40e_devlink_create_port(struct i40e_pf *pf)
231231
**/
232232
void i40e_devlink_destroy_port(struct i40e_pf *pf)
233233
{
234-
devlink_port_type_clear(&pf->devlink_port);
235234
devlink_port_unregister(&pf->devlink_port);
236235
}

0 commit comments

Comments
 (0)