Skip to content

Commit e95433c

Browse files
raagjadavandy-shev
authored andcommitted
pinctrl: intel: refine ->set_mux() hook
Utilize a temporary variable for common shift operation in ->set_mux() hook and improve readability while saving a few bytes. add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3) Function old new delta intel_pinmux_set_mux 245 242 -3 Total: Before=10472, After=10469, chg -0.03% Signed-off-by: Raag Jadav <raag.jadav@intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Link: https://lore.kernel.org/r/20230613085054.10976-2-raag.jadav@intel.com Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
1 parent c518d31 commit e95433c

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

drivers/pinctrl/intel/pinctrl-intel.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -411,18 +411,19 @@ static int intel_pinmux_set_mux(struct pinctrl_dev *pctldev,
411411
/* Now enable the mux setting for each pin in the group */
412412
for (i = 0; i < grp->grp.npins; i++) {
413413
void __iomem *padcfg0;
414-
u32 value;
414+
u32 value, pmode;
415415

416416
padcfg0 = intel_get_padcfg(pctrl, grp->grp.pins[i], PADCFG0);
417-
value = readl(padcfg0);
418417

418+
value = readl(padcfg0);
419419
value &= ~PADCFG0_PMODE_MASK;
420420

421421
if (grp->modes)
422-
value |= grp->modes[i] << PADCFG0_PMODE_SHIFT;
422+
pmode = grp->modes[i];
423423
else
424-
value |= grp->mode << PADCFG0_PMODE_SHIFT;
424+
pmode = grp->mode;
425425

426+
value |= pmode << PADCFG0_PMODE_SHIFT;
426427
writel(value, padcfg0);
427428
}
428429

0 commit comments

Comments
 (0)