Skip to content

Commit e937440

Browse files
Yuuoniybroonie
authored andcommitted
spi: meson-spicc: add IRQ check in meson_spicc_probe
This check misses checking for platform_get_irq()'s call and may passes the negative error codes to devm_request_irq(), which takes unsigned IRQ #, causing it to fail with -EINVAL, overriding an original error code. Stop calling devm_request_irq() with invalid IRQ #s. Fixes: 454fa27 ("spi: Add Meson SPICC driver") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220126110447.24549-1-linmq006@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 23e3404 commit e937440

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/spi/spi-meson-spicc.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -693,6 +693,11 @@ static int meson_spicc_probe(struct platform_device *pdev)
693693
writel_relaxed(0, spicc->base + SPICC_INTREG);
694694

695695
irq = platform_get_irq(pdev, 0);
696+
if (irq < 0) {
697+
ret = irq;
698+
goto out_master;
699+
}
700+
696701
ret = devm_request_irq(&pdev->dev, irq, meson_spicc_irq,
697702
0, NULL, spicc);
698703
if (ret) {

0 commit comments

Comments
 (0)