Skip to content

Commit e89cc14

Browse files
Wolfram Sangalexandrebelloni
authored andcommitted
i3c: dw: use parity8 helper instead of open coding it
The kernel has now a generic helper for getting parity with easier to understand semantics. Make use of it. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Link: https://lore.kernel.org/r/20250107090204.6593-4-wsa+renesas@sang-engineering.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 32a8d36 commit e89cc14

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

drivers/i3c/master/dw-i3c-master.c

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -251,14 +251,6 @@ struct dw_i3c_i2c_dev_data {
251251
struct i3c_generic_ibi_pool *ibi_pool;
252252
};
253253

254-
static u8 even_parity(u8 p)
255-
{
256-
p ^= p >> 4;
257-
p &= 0xf;
258-
259-
return (0x9669 >> p) & 1;
260-
}
261-
262254
static bool dw_i3c_master_supports_ccc_cmd(struct i3c_master_controller *m,
263255
const struct i3c_ccc_cmd *cmd)
264256
{
@@ -848,7 +840,7 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
848840
struct dw_i3c_xfer *xfer;
849841
struct dw_i3c_cmd *cmd;
850842
u32 olddevs, newdevs;
851-
u8 p, last_addr = 0;
843+
u8 last_addr = 0;
852844
int ret, pos;
853845

854846
ret = pm_runtime_resume_and_get(master->dev);
@@ -873,9 +865,9 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
873865
}
874866

875867
master->devs[pos].addr = ret;
876-
p = even_parity(ret);
877868
last_addr = ret;
878-
ret |= (p << 7);
869+
870+
ret |= parity8(ret) ? 0 : BIT(7);
879871

880872
writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(ret),
881873
master->regs +

0 commit comments

Comments
 (0)