Skip to content

Commit e87197f

Browse files
Dan Carpenterzhenyw
authored andcommitted
drm/i915/gvt: IS_ERR() vs NULL bug in intel_gvt_update_reg_whitelist()
The shmem_pin_map() function returns NULL, it doesn't return error pointers. Fixes: 97ea656 ("drm/i915/gvt: Parse default state to update reg whitelist") Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/Ysftoia2BPUyqVcD@kili Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
1 parent d72d69a commit e87197f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/gpu/drm/i915/gvt/cmd_parser.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3115,9 +3115,9 @@ void intel_gvt_update_reg_whitelist(struct intel_vgpu *vgpu)
31153115
continue;
31163116

31173117
vaddr = shmem_pin_map(engine->default_state);
3118-
if (IS_ERR(vaddr)) {
3119-
gvt_err("failed to map %s->default state, err:%zd\n",
3120-
engine->name, PTR_ERR(vaddr));
3118+
if (!vaddr) {
3119+
gvt_err("failed to map %s->default state\n",
3120+
engine->name);
31213121
return;
31223122
}
31233123

0 commit comments

Comments
 (0)