Skip to content

Commit e834166

Browse files
lf-hernandezmaddy-kerneldev
authored andcommitted
macintosh: declare ctl_table as const
Since commit 7abc9b5 ("sysctl: allow registration of const struct ctl_table"), the sysctl registration API allows struct ctl_table variables to be placed into read-only memory. mac_hid_files is registered as a sysctl table and should be treated as read-only. By declaring the mac_hid_files structure as const, we ensure that it cannot be accidentally modified. This change improves safety. Suggested-by: Thomas Weißschuh <linux@weissschuh.net> Suggested-by: Ricardo B. Marliere <rbm@suse.com> Reviewed-by: Ricardo B. Marliere <rbm@suse.com> Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> Link: https://patch.msgid.link/20241217-constify_ctl_table-v1-1-402ebceaeb8e@gmail.com
1 parent 65f5038 commit e834166

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/macintosh/mac_hid.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ static int mac_hid_toggle_emumouse(const struct ctl_table *table, int write,
215215
}
216216

217217
/* file(s) in /proc/sys/dev/mac_hid */
218-
static struct ctl_table mac_hid_files[] = {
218+
static const struct ctl_table mac_hid_files[] = {
219219
{
220220
.procname = "mouse_button_emulation",
221221
.data = &mouse_emulate_buttons,

0 commit comments

Comments
 (0)