Skip to content

Commit e807c2a

Browse files
ubizjakIngo Molnar
authored andcommitted
locking/x86: Implement local_xchg() using CMPXCHG without the LOCK prefix
Implement local_xchg() using the CMPXCHG instruction without the LOCK prefix. XCHG is expensive due to the implied LOCK prefix. The processor cannot prefetch cachelines if XCHG is used. Signed-off-by: Uros Bizjak <ubizjak@gmail.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Waiman Long <longman@redhat.com> Cc: Will Deacon <will.deacon@arm.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Paul E. McKenney <paulmck@kernel.org> Cc: "H. Peter Anvin" <hpa@zytor.com> Link: https://lore.kernel.org/r/20240124105816.612670-1-ubizjak@gmail.com
1 parent f3e3620 commit e807c2a

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

arch/x86/include/asm/local.h

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,20 @@ static inline bool local_try_cmpxchg(local_t *l, long *old, long new)
131131
(typeof(l->a.counter) *) old, new);
132132
}
133133

134-
/* Always has a lock prefix */
135-
#define local_xchg(l, n) (xchg(&((l)->a.counter), (n)))
134+
/*
135+
* Implement local_xchg using CMPXCHG instruction without the LOCK prefix.
136+
* XCHG is expensive due to the implied LOCK prefix. The processor
137+
* cannot prefetch cachelines if XCHG is used.
138+
*/
139+
static __always_inline long
140+
local_xchg(local_t *l, long n)
141+
{
142+
long c = local_read(l);
143+
144+
do { } while (!local_try_cmpxchg(l, &c, n));
145+
146+
return c;
147+
}
136148

137149
/**
138150
* local_add_unless - add unless the number is already a given value

0 commit comments

Comments
 (0)