Skip to content

Commit e7f2e65

Browse files
harperchenHans Verkuil
authored andcommitted
media: vcodec: Fix potential array out-of-bounds in encoder queue_setup
variable *nplanes is provided by user via system call argument. The possible value of q_data->fmt->num_planes is 1-3, while the value of *nplanes can be 1-8. The array access by index i can cause array out-of-bounds. Fix this bug by checking *nplanes against the array size. Fixes: 4e855a6 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver") Signed-off-by: Wei Chen <harperchen1110@gmail.com> Cc: stable@vger.kernel.org Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 parent 2908042 commit e7f2e65

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -821,6 +821,8 @@ static int vb2ops_venc_queue_setup(struct vb2_queue *vq,
821821
return -EINVAL;
822822

823823
if (*nplanes) {
824+
if (*nplanes != q_data->fmt->num_planes)
825+
return -EINVAL;
824826
for (i = 0; i < *nplanes; i++)
825827
if (sizes[i] < q_data->sizeimage[i])
826828
return -EINVAL;

0 commit comments

Comments
 (0)