Skip to content

Commit e6a3fc4

Browse files
jones-drewKAGA-KOKO
authored andcommitted
genirq/msi: Prevent NULL pointer dereference in msi_domain_debug_show()
irq_domain_debug_show_one() calls msi_domain_debug_show() with a non-NULL domain pointer and a NULL irq_data pointer. irq_debug_show_data() calls it with a NULL domain pointer. The domain pointer is not used, but the irq_data pointer is required to be non-NULL and lacks a NULL pointer check. Add the missing NULL pointer check to ensure there is a non-NULL irq_data pointer in msi_domain_debug_show() before dereferencing it. [ tglx: Massaged change log ] Fixes: 01499ae ("genirq/msi: Expose MSI message data in debugfs") Signed-off-by: Andrew Jones <ajones@ventanamicro.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/all/20250430124836.49964-2-ajones@ventanamicro.com
1 parent b443265 commit e6a3fc4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/irq/msi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,7 @@ static int msi_domain_translate(struct irq_domain *domain, struct irq_fwspec *fw
761761
static void msi_domain_debug_show(struct seq_file *m, struct irq_domain *d,
762762
struct irq_data *irqd, int ind)
763763
{
764-
struct msi_desc *desc = irq_data_get_msi_desc(irqd);
764+
struct msi_desc *desc = irqd ? irq_data_get_msi_desc(irqd) : NULL;
765765

766766
if (!desc)
767767
return;

0 commit comments

Comments
 (0)