Skip to content

Commit e62563d

Browse files
dos1dtor
authored andcommitted
Input: snvs_pwrkey - fix SNVS_HPVIDR1 register address
Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1 (chapters 57.9 and 6.4.5 respectively). Without this, trying to read the revision number results in 0 on all revisions, causing the i.MX6 quirk to apply on all platforms, which in turn causes the driver to synthesise power button release events instead of passing the real one as they happen even on platforms like i.MX8 where that's not wanted. Fixes: 1a26c92 ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q") Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/4599101.ElGaqSPkdT@pliszka Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 2fd003e commit e62563d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/input/keyboard/snvs_pwrkey.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include <linux/mfd/syscon.h>
2121
#include <linux/regmap.h>
2222

23-
#define SNVS_HPVIDR1_REG 0xF8
23+
#define SNVS_HPVIDR1_REG 0xBF8
2424
#define SNVS_LPSR_REG 0x4C /* LP Status Register */
2525
#define SNVS_LPCR_REG 0x38 /* LP Control Register */
2626
#define SNVS_HPSR_REG 0x14

0 commit comments

Comments
 (0)