Skip to content

Commit e5aa6d5

Browse files
bulwahntiwai
authored andcommitted
ALSA: hda/cs35l56: select intended config FW_CS_DSP
Commit 73cfbfa ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") adds configs SND_HDA_SCODEC_CS35L56_{I2C,SPI}, which selects the non-existing config CS_DSP. Note the renaming in commit d7cfdf1 ("firmware: cs_dsp: Rename KConfig symbol CS_DSP -> FW_CS_DSP"), though. Select the intended config FW_CS_DSP. This broken select command probably was not noticed as the configs also select SND_HDA_CS_DSP_CONTROLS and this then selects FW_CS_DSP. So, the select FW_CS_DSP could actually be dropped, but we will keep this redundancy in place as the author originally also intended to have this redundancy of selects in place. Fixes: 73cfbfa ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Reviewed-by: Simon Trimmer <simont@opensource.cirrus.com> Link: https://lore.kernel.org/r/20240209082044.3981-1-lukas.bulwahn@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent fddab35 commit e5aa6d5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sound/pci/hda/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ config SND_HDA_SCODEC_CS35L56_I2C
156156
depends on I2C
157157
depends on ACPI || COMPILE_TEST
158158
depends on SND_SOC
159-
select CS_DSP
159+
select FW_CS_DSP
160160
select SND_HDA_GENERIC
161161
select SND_SOC_CS35L56_SHARED
162162
select SND_HDA_SCODEC_CS35L56
@@ -171,7 +171,7 @@ config SND_HDA_SCODEC_CS35L56_SPI
171171
depends on SPI_MASTER
172172
depends on ACPI || COMPILE_TEST
173173
depends on SND_SOC
174-
select CS_DSP
174+
select FW_CS_DSP
175175
select SND_HDA_GENERIC
176176
select SND_SOC_CS35L56_SHARED
177177
select SND_HDA_SCODEC_CS35L56

0 commit comments

Comments
 (0)