Skip to content

Commit e3265a4

Browse files
namhyungPeter Zijlstra
authored andcommitted
perf/core: Inherit event_caps
It was reported that some perf event setup can make fork failed on ARM64. It was the case of a group of mixed hw and sw events and it failed in perf_event_init_task() due to armpmu_event_init(). The ARM PMU code checks if all the events in a group belong to the same PMU except for software events. But it didn't set the event_caps of inherited events and no longer identify them as software events. Therefore the test failed in a child process. A simple reproducer is: $ perf stat -e '{cycles,cs,instructions}' perf bench sched messaging # Running 'sched/messaging' benchmark: perf: fork(): Invalid argument The perf stat was fine but the perf bench failed in fork(). Let's inherit the event caps from the parent. Signed-off-by: Namhyung Kim <namhyung@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: <stable@vger.kernel.org> Link: https://lkml.kernel.org/r/20220328200112.457740-1-namhyung@kernel.org
1 parent ad4878d commit e3265a4

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

kernel/events/core.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11635,6 +11635,9 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu,
1163511635

1163611636
event->state = PERF_EVENT_STATE_INACTIVE;
1163711637

11638+
if (parent_event)
11639+
event->event_caps = parent_event->event_caps;
11640+
1163811641
if (event->attr.sigtrap)
1163911642
atomic_set(&event->event_limit, 1);
1164011643

0 commit comments

Comments
 (0)