Skip to content

Commit e1e5ef2

Browse files
leitaokuba-moo
authored andcommitted
net: fill in MODULE_DESCRIPTION()s for ppp
W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to the PPP modules. Signed-off-by: Breno Leitao <leitao@debian.org> Link: https://lore.kernel.org/r/20240214152741.670178-6-leitao@debian.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 4ad9e85 commit e1e5ef2

File tree

5 files changed

+5
-0
lines changed

5 files changed

+5
-0
lines changed

drivers/net/ppp/bsd_comp.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1166,5 +1166,6 @@ static void __exit bsdcomp_cleanup(void)
11661166

11671167
module_init(bsdcomp_init);
11681168
module_exit(bsdcomp_cleanup);
1169+
MODULE_DESCRIPTION("PPP BSD-Compress compression module");
11691170
MODULE_LICENSE("Dual BSD/GPL");
11701171
MODULE_ALIAS("ppp-compress-" __stringify(CI_BSD_COMPRESS));

drivers/net/ppp/ppp_async.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ struct asyncppp {
8787
static int flag_time = HZ;
8888
module_param(flag_time, int, 0);
8989
MODULE_PARM_DESC(flag_time, "ppp_async: interval between flagged packets (in clock ticks)");
90+
MODULE_DESCRIPTION("PPP async serial channel module");
9091
MODULE_LICENSE("GPL");
9192
MODULE_ALIAS_LDISC(N_PPP);
9293

drivers/net/ppp/ppp_deflate.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -630,6 +630,7 @@ static void __exit deflate_cleanup(void)
630630

631631
module_init(deflate_init);
632632
module_exit(deflate_cleanup);
633+
MODULE_DESCRIPTION("PPP Deflate compression module");
633634
MODULE_LICENSE("Dual BSD/GPL");
634635
MODULE_ALIAS("ppp-compress-" __stringify(CI_DEFLATE));
635636
MODULE_ALIAS("ppp-compress-" __stringify(CI_DEFLATE_DRAFT));

drivers/net/ppp/ppp_generic.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3604,6 +3604,7 @@ EXPORT_SYMBOL(ppp_input_error);
36043604
EXPORT_SYMBOL(ppp_output_wakeup);
36053605
EXPORT_SYMBOL(ppp_register_compressor);
36063606
EXPORT_SYMBOL(ppp_unregister_compressor);
3607+
MODULE_DESCRIPTION("Generic PPP layer driver");
36073608
MODULE_LICENSE("GPL");
36083609
MODULE_ALIAS_CHARDEV(PPP_MAJOR, 0);
36093610
MODULE_ALIAS_RTNL_LINK("ppp");

drivers/net/ppp/ppp_synctty.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -724,5 +724,6 @@ ppp_sync_cleanup(void)
724724

725725
module_init(ppp_sync_init);
726726
module_exit(ppp_sync_cleanup);
727+
MODULE_DESCRIPTION("PPP synchronous TTY channel module");
727728
MODULE_LICENSE("GPL");
728729
MODULE_ALIAS_LDISC(N_SYNC_PPP);

0 commit comments

Comments
 (0)