Skip to content

Commit e0e3aca

Browse files
committed
clk: mediatek: Use right match table, include mod_devicetable
This is copy/pasta that breaks modular builds. Fix the match table to use the right pointer, or the right device table type. And while we're including the header, fix the order to be linux, dt-bindings, and finally local. Cc: Garmin.Chang <Garmin.Chang@mediatek.com> Cc: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Fixes: f42b9e9 ("clk: mediatek: Add MT8188 wpesys clock support") Fixes: 0d2f2ce ("clk: mediatek: Add MT8188 adsp clock support") Fixes: e4aaa60 ("clk: mediatek: Add MT8188 vdosys0 clock support") Fixes: cfa4609 ("clk: mediatek: Add MT8188 vdosys1 clock support") Fixes: bb87c11 ("clk: mediatek: Add MT8188 vencsys clock support") Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/oe-kbuild-all/202304011039.UBDX1UOT-lkp@intel.com/ Link: https://lore.kernel.org/oe-kbuild-all/202304020649.QO2HlpD5-lkp@intel.com/ Link: https://lore.kernel.org/oe-kbuild-all/202304021055.WDhQPcoS-lkp@intel.com/ Signed-off-by: Stephen Boyd <sboyd@kernel.org> Link: https://lore.kernel.org/r/20230404204553.1256263-1-sboyd@kernel.org
1 parent 0d2f2ce commit e0e3aca

File tree

6 files changed

+22
-10
lines changed

6 files changed

+22
-10
lines changed

drivers/clk/mediatek/clk-mt8188-adsp_audio26m.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44
* Author: Garmin Chang <garmin.chang@mediatek.com>
55
*/
66

7-
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
87
#include <linux/clk-provider.h>
8+
#include <linux/mod_devicetable.h>
99
#include <linux/platform_device.h>
1010

11+
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
12+
1113
#include "clk-gate.h"
1214
#include "clk-mtk.h"
1315

@@ -34,7 +36,7 @@ static const struct of_device_id of_match_clk_mt8188_adsp_audio26m[] = {
3436
{ .compatible = "mediatek,mt8188-adsp-audio26m", .data = &adsp_audio26m_desc },
3537
{ /* sentinel */ }
3638
};
37-
MODULE_DEVICE_TABLE(platform, of_match_clk_mt8188_adsp_audio26m);
39+
MODULE_DEVICE_TABLE(of, of_match_clk_mt8188_adsp_audio26m);
3840

3941
static struct platform_driver clk_mt8188_adsp_audio26m_drv = {
4042
.probe = mtk_clk_simple_probe,

drivers/clk/mediatek/clk-mt8188-imp_iic_wrap.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44
* Author: Garmin Chang <garmin.chang@mediatek.com>
55
*/
66

7-
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
87
#include <linux/clk-provider.h>
8+
#include <linux/mod_devicetable.h>
99
#include <linux/platform_device.h>
1010

11+
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
12+
1113
#include "clk-gate.h"
1214
#include "clk-mtk.h"
1315

@@ -65,7 +67,7 @@ static const struct of_device_id of_match_clk_mt8188_imp_iic_wrap[] = {
6567
{ .compatible = "mediatek,mt8188-imp-iic-wrap-en", .data = &imp_iic_wrap_en_desc },
6668
{ /* sentinel */ }
6769
};
68-
MODULE_DEVICE_TABLE(platform, of_match_clk_mt8188_imp_iic_wrap);
70+
MODULE_DEVICE_TABLE(of, of_match_clk_mt8188_imp_iic_wrap);
6971

7072
static struct platform_driver clk_mt8188_imp_iic_wrap_drv = {
7173
.probe = mtk_clk_simple_probe,

drivers/clk/mediatek/clk-mt8188-vdo0.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44
* Author: Garmin Chang <garmin.chang@mediatek.com>
55
*/
66

7-
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
87
#include <linux/clk-provider.h>
8+
#include <linux/mod_devicetable.h>
99
#include <linux/platform_device.h>
1010

11+
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
12+
1113
#include "clk-gate.h"
1214
#include "clk-mtk.h"
1315

drivers/clk/mediatek/clk-mt8188-vdo1.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44
* Author: Garmin Chang <garmin.chang@mediatek.com>
55
*/
66

7-
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
87
#include <linux/clk-provider.h>
8+
#include <linux/mod_devicetable.h>
99
#include <linux/platform_device.h>
1010

11+
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
12+
1113
#include "clk-gate.h"
1214
#include "clk-mtk.h"
1315

drivers/clk/mediatek/clk-mt8188-venc.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44
* Author: Garmin Chang <garmin.chang@mediatek.com>
55
*/
66

7-
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
87
#include <linux/clk-provider.h>
8+
#include <linux/mod_devicetable.h>
99
#include <linux/platform_device.h>
1010

11+
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
12+
1113
#include "clk-gate.h"
1214
#include "clk-mtk.h"
1315

@@ -39,7 +41,7 @@ static const struct of_device_id of_match_clk_mt8188_venc1[] = {
3941
{ .compatible = "mediatek,mt8188-vencsys", .data = &venc1_desc },
4042
{ /* sentinel */ }
4143
};
42-
MODULE_DEVICE_TABLE(platform, of_match_clk_mt8188_venc1);
44+
MODULE_DEVICE_TABLE(of, of_match_clk_mt8188_venc1);
4345

4446
static struct platform_driver clk_mt8188_venc1_drv = {
4547
.probe = mtk_clk_simple_probe,

drivers/clk/mediatek/clk-mt8188-wpe.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44
* Author: Garmin Chang <garmin.chang@mediatek.com>
55
*/
66

7-
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
87
#include <linux/clk-provider.h>
8+
#include <linux/mod_devicetable.h>
99
#include <linux/platform_device.h>
1010

11+
#include <dt-bindings/clock/mediatek,mt8188-clk.h>
12+
1113
#include "clk-gate.h"
1214
#include "clk-mtk.h"
1315

@@ -88,7 +90,7 @@ static const struct of_device_id of_match_clk_mt8188_wpe[] = {
8890
{ .compatible = "mediatek,mt8188-wpesys-vpp0", .data = &wpe_vpp0_desc },
8991
{ /* sentinel */ }
9092
};
91-
MODULE_DEVICE_TABLE(platform, clk_mt8188_vpp1_id_table);
93+
MODULE_DEVICE_TABLE(of, of_match_clk_mt8188_wpe);
9294

9395
static struct platform_driver clk_mt8188_wpe_drv = {
9496
.probe = mtk_clk_simple_probe,

0 commit comments

Comments
 (0)