Skip to content

Commit dfe2aeb

Browse files
tmlindgregkh
authored andcommitted
serial: 8250: Fix oops for port->pm on uart_change_pm()
Unloading a hardware specific 8250 driver can produce error "Unable to handle kernel paging request at virtual address" about ten seconds after unloading the driver. This happens on uart_hangup() calling uart_change_pm(). Turns out commit 04e8279 ("serial: 8250: Reinit port->pm on port specific driver unbind") was only a partial fix. If the hardware specific driver has initialized port->pm function, we need to clear port->pm too. Just reinitializing port->ops does not do this. Otherwise serial8250_pm() will call port->pm() instead of serial8250_do_pm(). Fixes: 04e8279 ("serial: 8250: Reinit port->pm on port specific driver unbind") Signed-off-by: Tony Lindgren <tony@atomide.com> Link: https://lore.kernel.org/r/20230804131553.52927-1-tony@atomide.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent bbb4abb commit dfe2aeb

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/tty/serial/8250/8250_port.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3278,6 +3278,7 @@ void serial8250_init_port(struct uart_8250_port *up)
32783278

32793279
spin_lock_init(&port->lock);
32803280
port->ctrl_id = 0;
3281+
port->pm = NULL;
32813282
port->ops = &serial8250_pops;
32823283
port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
32833284

0 commit comments

Comments
 (0)