Skip to content

Commit dfd1033

Browse files
Russ Weightyilunxu1984
authored andcommitted
fpga: m10bmc-sec: Fix kconfig dependencies
The secure update driver depends on the firmware-upload functionality of the firmware-loader. The firmware-loader is carried in the firmware-class driver which is enabled with the tristate CONFIG_FW_LOADER option. The firmware-upload functionality is included in the firmware-class driver if the bool FW_UPLOAD config is set. The current dependency statement, "depends on FW_UPLOAD", is not adequate because it does not implicitly turn on FW_LOADER. Instead of adding a dependency, follow the convention used by drivers that require the FW_LOADER_USER_HELPER functionality of the firmware-loader by using select for both FW_LOADER and FW_UPLOAD. Fixes: bdf86d0 ("fpga: m10bmc-sec: create max10 bmc secure update") Reported-by: kernel test robot <lkp@intel.com> Cc: stable@vger.kernel.org Signed-off-by: Russ Weight <russell.h.weight@intel.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Xu Yilun <yilun.xu@intel.com> Link: https://lore.kernel.org/r/20221115001127.289890-1-russell.h.weight@intel.com Signed-off-by: Xu Yilun <yilun.xu@intel.com>
1 parent 9abf231 commit dfd1033

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/fpga/Kconfig

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,9 @@ config FPGA_MGR_VERSAL_FPGA
246246

247247
config FPGA_M10_BMC_SEC_UPDATE
248248
tristate "Intel MAX10 BMC Secure Update driver"
249-
depends on MFD_INTEL_M10_BMC && FW_UPLOAD
249+
depends on MFD_INTEL_M10_BMC
250+
select FW_LOADER
251+
select FW_UPLOAD
250252
help
251253
Secure update support for the Intel MAX10 board management
252254
controller.

0 commit comments

Comments
 (0)