Skip to content

Commit df5d4b6

Browse files
Yuuoniympe
authored andcommitted
powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address
of_get_next_parent() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() in the error path to avoid refcount leak. Fixes: ce21b3c ("[CELL] add support for MSI on Axon-based Cell systems") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20220605065129.63906-1-linmq006@gmail.com
1 parent 255b650 commit df5d4b6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

arch/powerpc/platforms/cell/axon_msi.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
223223
if (!prop) {
224224
dev_dbg(&dev->dev,
225225
"axon_msi: no msi-address-(32|64) properties found\n");
226+
of_node_put(dn);
226227
return -ENOENT;
227228
}
228229

0 commit comments

Comments
 (0)