Skip to content

Commit df0b5af

Browse files
zhangyi089tytso
authored andcommitted
ext4: remove the redundant folio_wait_stable()
__filemap_get_folio() with FGP_WRITEBEGIN parameter has already wait for stable folio, so remove the redundant folio_wait_stable() in ext4_da_write_begin(), it was left over from the commit cc88323 ("ext4: drop unnecessary journal handle in delalloc write") that removed the retry getting page logic. Fixes: cc88323 ("ext4: drop unnecessary journal handle in delalloc write") Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20240419023005.2719050-1-yi.zhang@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 3f4830a commit df0b5af

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

fs/ext4/inode.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2887,9 +2887,6 @@ static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
28872887
if (IS_ERR(folio))
28882888
return PTR_ERR(folio);
28892889

2890-
/* In case writeback began while the folio was unlocked */
2891-
folio_wait_stable(folio);
2892-
28932890
#ifdef CONFIG_FS_ENCRYPTION
28942891
ret = ext4_block_write_begin(folio, pos, len, ext4_da_get_block_prep);
28952892
#else

0 commit comments

Comments
 (0)