Skip to content

Commit de379df

Browse files
committed
selftests: drv-net: rss_ctx: add missing cleanup in queue reconfigure
Commit under Fixes adds ntuple rules but never deletes them. Fixes: 29a4bc1 ("selftest: extend test_rss_context_queue_reconfigure for action addition") Reviewed-by: Joe Damato <jdamato@fastly.com> Link: https://patch.msgid.link/20250201013040.725123-4-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 2b91cc1 commit de379df

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

tools/testing/selftests/drivers/net/hw/rss_ctx.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,7 @@ def test_rss_queue_reconfigure(cfg, main_ctx=True):
252252
try:
253253
# this targets queue 4, which doesn't exist
254254
ntuple2 = ethtool_create(cfg, "-N", flow)
255+
defer(ethtool, f"-N {cfg.ifname} delete {ntuple2}")
255256
except CmdExitFailure:
256257
pass
257258
else:
@@ -260,6 +261,7 @@ def test_rss_queue_reconfigure(cfg, main_ctx=True):
260261
ethtool(f"-X {cfg.ifname} {ctx_ref} weight 1 0 1 0")
261262
# ntuple rule therefore targets queues 1 and 3
262263
ntuple2 = ethtool_create(cfg, "-N", flow)
264+
defer(ethtool, f"-N {cfg.ifname} delete {ntuple2}")
263265
# should replace existing filter
264266
ksft_eq(ntuple, ntuple2)
265267
_send_traffic_check(cfg, port, ctx_ref, { 'target': (1, 3),

0 commit comments

Comments
 (0)