Skip to content

Commit ddac3d8

Browse files
committed
Merge tag 'x86_urgent_for_v6.8_rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull x86 fix from Borislav Petkov: - Use a GB page for identity mapping only when memory of this size is requested so that mapping of reserved regions is prevented which would otherwise lead to system crashes on UV machines * tag 'x86_urgent_for_v6.8_rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: x86/mm/ident_map: Use gbpages only where full GB page should be mapped.
2 parents 7cb7c32 + d794734 commit ddac3d8

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

arch/x86/mm/ident_map.c

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,31 @@ static int ident_pud_init(struct x86_mapping_info *info, pud_t *pud_page,
2626
for (; addr < end; addr = next) {
2727
pud_t *pud = pud_page + pud_index(addr);
2828
pmd_t *pmd;
29+
bool use_gbpage;
2930

3031
next = (addr & PUD_MASK) + PUD_SIZE;
3132
if (next > end)
3233
next = end;
3334

34-
if (info->direct_gbpages) {
35-
pud_t pudval;
35+
/* if this is already a gbpage, this portion is already mapped */
36+
if (pud_large(*pud))
37+
continue;
38+
39+
/* Is using a gbpage allowed? */
40+
use_gbpage = info->direct_gbpages;
3641

37-
if (pud_present(*pud))
38-
continue;
42+
/* Don't use gbpage if it maps more than the requested region. */
43+
/* at the begining: */
44+
use_gbpage &= ((addr & ~PUD_MASK) == 0);
45+
/* ... or at the end: */
46+
use_gbpage &= ((next & ~PUD_MASK) == 0);
47+
48+
/* Never overwrite existing mappings */
49+
use_gbpage &= !pud_present(*pud);
50+
51+
if (use_gbpage) {
52+
pud_t pudval;
3953

40-
addr &= PUD_MASK;
4154
pudval = __pud((addr - info->offset) | info->page_flag);
4255
set_pud(pud, pudval);
4356
continue;

0 commit comments

Comments
 (0)