ALSA: hda: cs35l41: Fix missing error code in cs35l41_smart_amp()

harshimogalapalli · tiwai · commit dc6e08b1a2ae · 2023-10-31T18:30:16.000+01:00
When firmware status is invalid, assign -EINVAL to ret as ret is '0' at that point and returning success is incorrect when firmware status is invalid. Fixes: a51d8ba ("ALSA: hda: cs35l41: Check CSPL state after loading firmware") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Link: https://lore.kernel.org/r/20231030070836.3234385-1-harshit.m.mogalapalli@oracle.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
@@ -1042,6 +1042,7 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41)
 	default:
 		dev_err(cs35l41->dev, "Firmware status is invalid: %u\n",
 			fw_status);
+		ret = -EINVAL;
 		goto clean_dsp;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1042,6 +1042,7 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41)`
`1042`	`1042`	`default:`
`1043`	`1043`	`dev_err(cs35l41->dev, "Firmware status is invalid: %u\n",`
`1044`	`1044`	`fw_status);`
	`1045`	`+ ret = -EINVAL;`
`1045`	`1046`	`goto clean_dsp;`
`1046`	`1047`	`}`
`1047`	`1048`