Skip to content

Commit db08c53

Browse files
florommelakpm00
authored andcommitted
scripts/gdb: fix parameter handling in $lx_per_cpu
Before, the script tried to get the address by constructing a pointer to the parameter (by name). However, since GDB now passes the parameter as a GdbValue, we cannot get its name. Instead, we retrieve the address through GdbValue's address attribute. Before: >>> p $lx_per_cpu(cpu_info) Traceback (most recent call last): File "./scripts/gdb/linux/cpus.py", line 152, in invoke var_ptr = gdb.parse_and_eval("&" + var_name.string()) ^^^^^^^^^^^^^^^^^ gdb.error: Trying to read string with inappropriate type `struct cpuinfo_x86'. Link: https://lkml.kernel.org/r/20240425153501.749966-3-mail@florommel.de Signed-off-by: Florian Rommel <mail@florommel.de> Cc: Andrew Jones <ajones@ventanamicro.com> Cc: Deepak Gupta <debug@rivosinc.com> Cc: Jan Kiszka <jan.kiszka@siemens.com> Cc: Kieran Bingham <kbingham@kernel.org> Cc: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> Cc: Palmer Dabbelt <palmer@rivosinc.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent ec0b6d1 commit db08c53

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

scripts/gdb/linux/cpus.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,8 @@ class PerCpu(gdb.Function):
152152
def __init__(self):
153153
super(PerCpu, self).__init__("lx_per_cpu")
154154

155-
def invoke(self, var_name, cpu=-1):
156-
var_ptr = gdb.parse_and_eval("&" + var_name.string())
157-
return per_cpu(var_ptr, cpu)
155+
def invoke(self, var, cpu=-1):
156+
return per_cpu(var.address, cpu)
158157

159158

160159
PerCpu()

0 commit comments

Comments
 (0)