Skip to content

Commit dacafdc

Browse files
committed
drm/tests: modeset: Fix drm_display_mode memory leak
drm_mode_find_dmt() returns a drm_display_mode that needs to be destroyed later one. The drm_test_pick_cmdline_res_1920_1080_60() test never does however, which leads to a memory leak. Let's make sure it's freed. Reported-by: Philipp Stanner <phasta@mailbox.org> Closes: https://lore.kernel.org/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.camel@mailbox.org/ Fixes: 8fc0380 ("drm/client: Add some tests for drm_connector_pick_cmdline_mode()") Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://lore.kernel.org/r/20250408-drm-kunit-drm-display-mode-memleak-v1-2-996305a2e75a@kernel.org Signed-off-by: Maxime Ripard <mripard@kernel.org>
1 parent 13c1d5f commit dacafdc

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/gpu/drm/tests/drm_client_modeset_test.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@ static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
9595
expected_mode = drm_mode_find_dmt(priv->drm, 1920, 1080, 60, false);
9696
KUNIT_ASSERT_NOT_NULL(test, expected_mode);
9797

98+
ret = drm_kunit_add_mode_destroy_action(test, expected_mode);
99+
KUNIT_ASSERT_EQ(test, ret, 0);
100+
98101
KUNIT_ASSERT_TRUE(test,
99102
drm_mode_parse_command_line_for_connector(cmdline,
100103
connector,

0 commit comments

Comments
 (0)