Skip to content

Commit da85f0a

Browse files
andy-shevsuperna9999
authored andcommitted
drm/panel: ili9341: Use predefined error codes
In one case the -1 is returned which is quite confusing code for the wrong device ID, in another the ret is returning instead of plain 0 that also confusing as readed may ask the possible meaning of positive codes, which are never the case there. Convert both to use explicit predefined error codes to make it clear what's going on there. Fixes: 5a04227 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev> Link: https://lore.kernel.org/r/20240425142706.2440113-4-andriy.shevchenko@linux.intel.com Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240425142706.2440113-4-andriy.shevchenko@linux.intel.com
1 parent 740fc1e commit da85f0a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/panel/panel-ilitek-ili9341.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ static int ili9341_dpi_prepare(struct drm_panel *panel)
422422

423423
ili9341_dpi_init(ili);
424424

425-
return ret;
425+
return 0;
426426
}
427427

428428
static int ili9341_dpi_enable(struct drm_panel *panel)
@@ -726,7 +726,7 @@ static int ili9341_probe(struct spi_device *spi)
726726
else if (!strcmp(id->name, "yx240qv29"))
727727
return ili9341_dbi_probe(spi, dc, reset);
728728

729-
return -1;
729+
return -ENODEV;
730730
}
731731

732732
static void ili9341_remove(struct spi_device *spi)

0 commit comments

Comments
 (0)